Revert "client: optimize rename operation under different quota root"#38112
Merged
batrick merged 1 commit intoceph:masterfrom Dec 2, 2020
Merged
Revert "client: optimize rename operation under different quota root"#38112batrick merged 1 commit intoceph:masterfrom
batrick merged 1 commit intoceph:masterfrom
Conversation
This reverts commit b8954e5. The possibility of doing a cross quota realms rename in the kernel client has been reverted because there was a corner case where it wasn't being handled correctly: mkdir files limit truncate files/file -s 10G setfattr limit -n ceph.quota.max_bytes -v 1000000 mv files limit/ The above would succeed because the kernel client won't immediately notify the MDSs with the new file size when doing a truncate(2), and thus the quota realms stats won't be updated. Although the fuse client doesn't have this issue, multi-client scenarios may be impacted. URL: https://tracker.ceph.com/issues/48203 Signed-off-by: Luis Henriques <lhenriques@suse.de>
batrick
approved these changes
Nov 17, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b8954e5.
The possibility of doing a cross quota realms rename in the kernel client
has been reverted because there was a corner case where it wasn't being
handled correctly:
mkdir files limit
truncate files/file -s 10G
setfattr limit -n ceph.quota.max_bytes -v 1000000
mv files limit/
The above would succeed because the kernel client won't immediately notify
the MDSs with the new file size when doing a truncate(2), and thus the
quota realms stats won't be updated.
Although the fuse client doesn't have this issue, multi-client scenarios
may be impacted.
URL: https://tracker.ceph.com/issues/48203
Signed-off-by: Luis Henriques lhenriques@suse.de
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox