Skip to content

vstart_runner: accepts multiple commands as str too#37655

Merged
vshankar merged 8 commits intoceph:masterfrom
rishabh-d-dave:vr-run-multiple-cmds
May 4, 2022
Merged

vstart_runner: accepts multiple commands as str too#37655
vshankar merged 8 commits intoceph:masterfrom
rishabh-d-dave:vr-run-multiple-cmds

Conversation

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented Oct 13, 2020 •
edited
Loading

Teuthology's orchestra.remote.run() can execute multiple commands passed
to it in form of character string where commands are separated by
newlines. Let's add that ability to vstart_runner.LocalRemote.run() as
well.

Fixes: https://tracker.ceph.com/issues/47849

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@rishabh-d-dave rishabh-d-dave requested review from a team and batrick October 13, 2020 14:41
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 14, 2020

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 14, 2020

Link to laat API job - https://jenkins.ceph.com/job/ceph-api/5023/

@rishabh-d-dave rishabh-d-dave mentioned this pull request Oct 20, 2020
Merged
3 tasks
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Nov 9, 2020

The persistent error on Ceph API tests (see https://jenkins.ceph.com/job/ceph-api/6273/) is due to a bug in mgr_test_case.py. Here's the fix for that bug - #37992.

Marking this as DNM until that PR merges.

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Nov 9, 2020

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Nov 9, 2020

With the fix for dashboard QA, the Ceph API tests passed - https://jenkins.ceph.com/job/ceph-api/6374/

@github-actions github-actions bot removed the cephfs Ceph File System label Nov 18, 2020
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Nov 18, 2020

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Nov 18, 2020

Following is the part of logs where the failure occurred -

2020-11-18 08:23:30,396.396 INFO:__main__:Starting test: test_module_commands (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-18 08:23:30,396.396 INFO:__main__:> ./bin/ceph log Starting test tasks.mgr.test_module_selftest.TestModuleSelftest.test_module_commands
2020-11-18 08:23:31,402.402 INFO:__main__:> ps ww -u1108
2020-11-18 08:23:31,432.432 INFO:__main__:Found ps line for daemon: 25255 ?        Ssl    0:05 ./bin/./ceph-mgr -i x
2020-11-18 08:23:31,433.433 INFO:__main__:> ps ww -u1108
2020-11-18 08:23:31,464.464 INFO:__main__:Found ps line for daemon: 25255 ?        Ssl    0:05 ./bin/./ceph-mgr -i x
2020-11-18 08:23:31,465.465 INFO:__main__:Killing PID 25255 for mgr.x
2020-11-18 08:23:31,465.465 INFO:__main__:> ps ww -u1108
2020-11-18 08:23:31,495.495 INFO:__main__:No match for mgr x
2020-11-18 08:23:31,496.496 INFO:__main__:> ps ww -u1108
2020-11-18 08:23:31,520.520 INFO:__main__:No match for mgr x
2020-11-18 08:23:31,521.521 INFO:__main__:> ./bin/ceph mgr fail x
2020-11-18 08:23:33,038.038 INFO:__main__:> ./bin/ceph mgr module ls
2020-11-18 08:23:33,705.705 INFO:__main__:> ./bin/ceph mgr module disable iostat
2020-11-18 08:23:34,434.434 INFO:__main__:> ./bin/ceph mgr module disable selftest
2020-11-18 08:23:35,475.475 INFO:__main__:> ps ww -u1108
2020-11-18 08:23:35,504.504 INFO:__main__:No match for mgr x
2020-11-18 08:23:35,505.505 INFO:__main__:> ./bin/./ceph-mgr -i x
2020-11-18 08:23:35,634.634 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-18 08:23:41,292.292 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-18 08:23:41,955.955 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-18 08:23:42,615.615 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-18 08:23:43,275.275 INFO:__main__:> ./bin/ceph mgr module ls
2020-11-18 08:23:43,925.925 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-18 08:23:44,593.593 INFO:__main__:> ./bin/ceph mgr metadata
2020-11-18 08:23:45,218.218 INFO:tasks.mgr.mgr_test_case:Loading Mgr module selftest ...
2020-11-18 08:23:45,219.219 INFO:__main__:> ./bin/ceph mgr module enable selftest --force
2020-11-18 08:23:46,684.684 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-18 08:23:52,349.349 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-18 08:23:58,017.017 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-18 08:23:58,678.678 INFO:tasks.mgr.mgr_test_case:Restarted after module load (new active x/5960)
2020-11-18 08:23:58,680.680 INFO:__main__:> ./bin/ceph mgr module disable selftest
2020-11-18 08:24:00,193.193 INFO:__main__:> ./bin/ceph mgr self-test run
2020-11-18T08:24:00.427+0000 7f010a95f700 -1 WARNING: all dangerous and experimental features are enabled.
2020-11-18T08:24:00.483+0000 7f010a95f700 -1 WARNING: all dangerous and experimental features are enabled.
Error ENOTSUP: Module 'selftest' is not enabled (required by command

Since locally this test passed for this branch, I am running API tests once again.

Link to the previous run - https://jenkins.ceph.com/job/ceph-api/6994/

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Nov 18, 2020

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Nov 19, 2020

Strange, I see "Took 0 ms on master" on API test job - https://jenkins.ceph.com/job/ceph-api/7040/. Retriggering...

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Nov 19, 2020

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Nov 19, 2020

Seeing the same failure again -

2020-11-19 07:02:52,275.275 INFO:__main__:Starting test: test_module_commands (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-19 07:02:52,275.275 INFO:__main__:> ./bin/ceph log Starting test tasks.mgr.test_module_selftest.TestModuleSelftest.test_module_commands
2020-11-19 07:02:53,305.305 INFO:__main__:> ps ww -u1001
2020-11-19 07:02:53,319.319 INFO:__main__:Found ps line for daemon: 30419 ?        Ssl    0:04 ./bin/./ceph-mgr -i x
2020-11-19 07:02:53,319.319 INFO:__main__:> ps ww -u1001
2020-11-19 07:02:53,337.337 INFO:__main__:Found ps line for daemon: 30419 ?        Ssl    0:04 ./bin/./ceph-mgr -i x
2020-11-19 07:02:53,337.337 INFO:__main__:Killing PID 30419 for mgr.x
2020-11-19 07:02:53,338.338 INFO:__main__:> ps ww -u1001
2020-11-19 07:02:53,350.350 INFO:__main__:No match for mgr x
2020-11-19 07:02:53,351.351 INFO:__main__:> ps ww -u1001
2020-11-19 07:02:53,369.369 INFO:__main__:No match for mgr x
2020-11-19 07:02:53,370.370 INFO:__main__:> ./bin/ceph mgr fail x
2020-11-19 07:02:54,359.359 INFO:__main__:> ./bin/ceph mgr module ls
2020-11-19 07:02:54,922.922 INFO:__main__:> ./bin/ceph mgr module disable iostat
2020-11-19 07:02:56,371.371 INFO:__main__:> ./bin/ceph mgr module disable selftest
2020-11-19 07:02:57,409.409 INFO:__main__:> ps ww -u1001
2020-11-19 07:02:57,430.430 INFO:__main__:No match for mgr x
2020-11-19 07:02:57,431.431 INFO:__main__:> ./bin/./ceph-mgr -i x
2020-11-19 07:02:57,528.528 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-19 07:03:03,076.076 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-19 07:03:03,625.625 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-19 07:03:04,175.175 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-19 07:03:04,732.732 INFO:__main__:> ./bin/ceph mgr module ls
2020-11-19 07:03:05,289.289 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-19 07:03:05,836.836 INFO:__main__:> ./bin/ceph mgr metadata
2020-11-19 07:03:06,395.395 INFO:tasks.mgr.mgr_test_case:Loading Mgr module selftest ...
2020-11-19 07:03:06,396.396 INFO:__main__:> ./bin/ceph mgr module enable selftest --force
2020-11-19 07:03:07,388.388 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-19 07:03:12,945.945 INFO:__main__:> ./bin/ceph mgr dump --format=json-pretty
2020-11-19 07:03:13,516.516 INFO:tasks.mgr.mgr_test_case:Restarted after module load (new active x/5935)
2020-11-19 07:03:13,517.517 INFO:__main__:> ./bin/ceph mgr module disable selftest
2020-11-19 07:03:14,321.321 INFO:__main__:> ./bin/ceph mgr self-test run
2020-11-19T07:03:14.499+0000 7f318add9700 -1 WARNING: all dangerous and experimental features are enabled.
2020-11-19T07:03:14.531+0000 7f318add9700 -1 WARNING: all dangerous and experimental features are enabled.
Error ENOTSUP: Module 'selftest' is not enabled (required by command 'mgr self-test run'): use `ceph mgr module enable selftest` to enable it

@rishabh-d-dave rishabh-d-dave requested a review from lxbsz November 20, 2020 09:28
lxbsz
lxbsz reviewed Nov 24, 2020
View reviewed changes
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Dec 1, 2020

jenkins test api

1 similar comment
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Dec 2, 2020

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 16, 2022

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 17, 2022

Link to Ceph API job - https://jenkins.ceph.com/job/ceph-api/35080/

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 17, 2022

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 17, 2022

Link to Ceph API CI job for run before last push - https://jenkins.ceph.com/job/ceph-api/35074/.

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 18, 2022 •
edited
Loading

Link to latest Ceph API CI job - https://jenkins.ceph.com/job/ceph-api/3508. Failure -

2022-04-17 16:34:36,374.374 INFO:__main__:Starting test: test_a_set_login_credentials (tasks.mgr.dashboard.test_auth.AuthTest)
2022-04-17T16:34:38.185+0000 7ffa86a5f700 -1 WARNING: all dangerous and experimental features are enabled.
2022-04-17T16:34:38.205+0000 7ffa86a5f700 -1 WARNING: all dangerous and experimental features are enabled.
Error ENOENT: User 'admin2' does not exist
2022-04-17T16:34:40.613+0000 7f80e44ba700 -1 WARNING: all dangerous and experimental features are enabled.
2022-04-17T16:34:40.633+0000 7f80e44ba700 -1 WARNING: all dangerous and experimental features are enabled.
Error ENOENT: User 'admin2' does not exist

2022-04-17 16:35:17,771.771 INFO:__main__:Starting test: test_login_without_password (tasks.mgr.dashboard.test_auth.AuthTest)
2022-04-17T16:35:19.322+0000 7f2001afc700 -1 WARNING: all dangerous and experimental features are enabled.
2022-04-17T16:35:19.342+0000 7f2001afc700 -1 WARNING: all dangerous and experimental features are enabled.
Error ENOENT: User 'admin2' does not exist
2022-04-17T16:35:19.698+0000 7f03926cf700 -1 WARNING: all dangerous and experimental features are enabled.
2022-04-17T16:35:19.722+0000 7f03926cf700 -1 WARNING: all dangerous and experimental features are enabled.

2022-04-17 17:30:30,157.157 INFO:__main__:Use the selftest module to test the cluster/audit log interface. ... ERROR
2022-04-17 17:30:30,157.157 INFO:__main__:
2022-04-17 17:30:30,157.157 INFO:__main__:======================================================================
2022-04-17 17:30:30,157.157 INFO:__main__:ERROR: test_selftest_cluster_log (tasks.mgr.test_module_selftest.TestModuleSelftest)
2022-04-17 17:30:30,157.157 INFO:__main__:Use the selftest module to test the cluster/audit log interface.
2022-04-17 17:30:30,158.158 INFO:__main__:
2022-04-17 17:30:30,158.158 INFO:__main__:----------------------------------------------------------------------
2022-04-17 17:30:30,158.158 INFO:__main__:Traceback (most recent call last):
2022-04-17 17:30:30,158.158 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/test_module_selftest.py", line 238, in test_selftest_cluster_log
2022-04-17 17:30:30,158.158 INFO:__main__:    self.mgr_cluster.mon_manager.raw_cluster_cmd(
2022-04-17 17:30:30,158.158 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/ceph_test_case.py", line 131, in __exit__
2022-04-17 17:30:30,158.158 INFO:__main__:    self.watcher_process.stdin.close()
2022-04-17 17:30:30,158.158 INFO:__main__:  File "../qa/tasks/vstart_runner.py", line 292, in close
2022-04-17 17:30:30,158.158 INFO:__main__:    self.mount_daemon.kill()
2022-04-17 17:30:30,158.158 INFO:__main__:  File "../qa/tasks/vstart_runner.py", line 281, in kill
2022-04-17 17:30:30,159.159 INFO:__main__:    safe_kill(self.subproc.pid)
2022-04-17 17:30:30,159.159 INFO:__main__:  File "../qa/tasks/vstart_runner.py", line 612, in safe_kill
2022-04-17 17:30:30,159.159 INFO:__main__:    return os.kill(pid, signal.SIGKILL)
2022-04-17 17:30:30,159.159 INFO:__main__:PermissionError: [Errno 1] Operation not permitted
2022-04-17 17:30:30,159.159 INFO:__main__:
Cannot find device "ceph-brx"
2022-04-17 17:30:30,186.186 INFO:__main__:
2022-04-17 17:30:30,186.186 INFO:__main__:----------------------------------------------------------------------
2022-04-17 17:30:30,186.186 INFO:__main__:Ran 299 tests in 3575.167s
2022-04-17 17:30:30,186.186 INFO:__main__:
2022-04-17 17:30:30,187.187 INFO:__main__:FAILED (errors=1, skipped=1)
2022-04-17 17:30:30,187.187 INFO:__main__:
2022-04-17 17:30:30,187.187 INFO:__main__:
2022-04-17 17:30:30,187.187 INFO:__main__:======================================================================
2022-04-17 17:30:30,187.187 INFO:__main__:ERROR: test_selftest_cluster_log (tasks.mgr.test_module_selftest.TestModuleSelftest)
2022-04-17 17:30:30,187.187 INFO:__main__:Use the selftest module to test the cluster/audit log interface.
2022-04-17 17:30:30,187.187 INFO:__main__:----------------------------------------------------------------------
2022-04-17 17:30:30,187.187 INFO:__main__:Traceback (most recent call last):
2022-04-17 17:30:30,187.187 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/test_module_selftest.py", line 238, in test_selftest_cluster_log
2022-04-17 17:30:30,187.187 INFO:__main__:    self.mgr_cluster.mon_manager.raw_cluster_cmd(
2022-04-17 17:30:30,187.187 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/ceph_test_case.py", line 131, in __exit__
2022-04-17 17:30:30,187.187 INFO:__main__:    self.watcher_process.stdin.close()
2022-04-17 17:30:30,188.188 INFO:__main__:  File "../qa/tasks/vstart_runner.py", line 292, in close
2022-04-17 17:30:30,188.188 INFO:__main__:    self.mount_daemon.kill()
2022-04-17 17:30:30,188.188 INFO:__main__:  File "../qa/tasks/vstart_runner.py", line 281, in kill
2022-04-17 17:30:30,188.188 INFO:__main__:    safe_kill(self.subproc.pid)
2022-04-17 17:30:30,188.188 INFO:__main__:  File "../qa/tasks/vstart_runner.py", line 612, in safe_kill
2022-04-17 17:30:30,188.188 INFO:__main__:    return os.kill(pid, signal.SIGKILL)
2022-04-17 17:30:30,188.188 INFO:__main__:PermissionError: [Errno 1] Operation not permitted

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 18, 2022 •
edited
Loading

Ceph API CI job failed. Link - https://jenkins.ceph.com/job/ceph-api/35126/consoleFull#12945576334b0cfa0c-a892-49e0-a359-82544e1a192e. Following are problematic error messages I could find -

2022-04-18 11:11:49,513.513 INFO:__main__:Stopped test: test_version (tasks.mgr.dashboard.test_api.VersionReqTest) in 1.5585s
2022-04-18 11:12:32,556.556 INFO:__main__:Starting test: test_a_set_login_credentials (tasks.mgr.dashboard.test_auth.AuthTest)
2022-04-18T11:12:34.161+0000 7f7776be5700 -1 WARNING: all dangerous and experimental features are enabled.
2022-04-18T11:12:34.181+0000 7f7776be5700 -1 WARNING: all dangerous and experimental features are enabled.
Error ENOENT: User 'admin2' does not exist
2022-04-18T11:12:36.609+0000 7fd56e945700 -1 WARNING: all dangerous and experimental features are enabled.
2022-04-18T11:12:36.621+0000 7fd56e945700 -1 WARNING: all dangerous and experimental features are enabled.
Error ENOENT: User 'admin2' does not exist
2022-04-18 11:12:39,872.872 INFO:__main__:test_standby (tasks.mgr.test_dashboard.TestDashboard) ... ok

2022-04-18 11:13:13,597.597 INFO:__main__:Starting test: test_login_without_password (tasks.mgr.dashboard.test_auth.AuthTest)
2022-04-18T11:13:15.098+0000 7f1fb97aa700 -1 WARNING: all dangerous and experimental features are enabled.
2022-04-18T11:13:15.118+0000 7f1fb97aa700 -1 WARNING: all dangerous and experimental features are enabled.
Error ENOENT: User 'admin2' does not exist
2022-04-18T11:13:15.498+0000 7fabf1217700 -1 WARNING: all dangerous and experimental features are enabled.
2022-04-18T11:13:15.518+0000 7fabf1217700 -1 WARNING: all dangerous and experimental features are enabled.
Error EINVAL: Input file not specified: Please specify the file containing password/secret with "-i" option
2022-04-18 11:13:16,602.602 INFO:__main__:Stopped test: test_login_without_password (tasks.mgr.dashboard.test_auth.AuthTest) in 3.005544s

2022-04-18 12:08:32,836.836 INFO:__main__:======================================================================
2022-04-18 12:08:32,836.836 INFO:__main__:ERROR: test_selftest_cluster_log (tasks.mgr.test_module_selftest.TestModuleSelftest)
2022-04-18 12:08:32,836.836 INFO:__main__:Use the selftest module to test the cluster/audit log interface.
2022-04-18 12:08:32,836.836 INFO:__main__:
2022-04-18 12:08:32,836.836 INFO:__main__:----------------------------------------------------------------------
2022-04-18 12:08:32,837.837 INFO:__main__:Traceback (most recent call last):
2022-04-18 12:08:32,837.837 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/test_module_selftest.py", line 238, in test_selftest_cluster_log
2022-04-18 12:08:32,837.837 INFO:__main__:    self.mgr_cluster.mon_manager.raw_cluster_cmd(
2022-04-18 12:08:32,837.837 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/ceph_test_case.py", line 131, in __exit__
2022-04-18 12:08:32,837.837 INFO:__main__:    self.watcher_process.stdin.close()
2022-04-18 12:08:32,837.837 INFO:__main__:  File "../qa/tasks/vstart_runner.py", line 292, in close
2022-04-18 12:08:32,837.837 INFO:__main__:    self.mount_daemon.kill()
2022-04-18 12:08:32,837.837 INFO:__main__:  File "../qa/tasks/vstart_runner.py", line 281, in kill
2022-04-18 12:08:32,837.837 INFO:__main__:    safe_kill(self.subproc.pid)
2022-04-18 12:08:32,837.837 INFO:__main__:  File "../qa/tasks/vstart_runner.py", line 612, in safe_kill
2022-04-18 12:08:32,837.837 INFO:__main__:    return os.kill(pid, signal.SIGKILL)
2022-04-18 12:08:32,837.837 INFO:__main__:PermissionError: [Errno 1] Operation not permitted

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 18, 2022

Retriggering make check since error from previous make check job doesn't look releveant.

 31 - run-rbd-unit-tests-1.sh (Failed)

https://jenkins.ceph.com/job/ceph-pull-requests/93743/

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 18, 2022

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 19, 2022 •
edited
Loading

https://jenkins.ceph.com/job/ceph-api/35154/

The first two snippets can still be found in console output.

Following is new -

2022-04-18 18:20:17,973.973 INFO:__main__:Starting test: test_module_commands (tasks.mgr.test_module_selftest.TestModuleSelftest)
That module-handled commands have appropriate  behavior on
2022-04-18T18:20:44.343+0000 7fbe9721e700 -1 WARNING: all dangerous and experimental features are enabled.
2022-04-18T18:20:44.359+0000 7fbe95fbc700 -1 WARNING: all dangerous and experimental features are enabled.
Error ENOTSUP: Module 'selftest' is not enabled (required by command 'mgr self-test run'): use `ceph mgr module enable selftest` to enable it
2022-04-18T18:20:51.792+0000 7f429a5b6700 -1 WARNING: all dangerous and experimental features are enabled.
2022-04-18T18:20:51.804+0000 7f4299354700 -1 WARNING: all dangerous and experimental features are enabled.
no valid command found; 10 closest matches:
osd perf
osd df [<output_method:plain|tree>] [<filter_by:class|name>] [<filter>]
osd blocked-by
osd pool stats [<pool_name>]
osd pool scrub <who>...
osd pool deep-scrub <who>...
osd pool repair <who>...
osd pool force-recovery <who>...
osd pool force-backfill <who>...
osd pool cancel-force-recovery <who>...
Error EINVAL: invalid command
2022-04-18T18:21:05.712+0000 7fc9329e7700 -1 WARNING: all dangerous and experimental features are enabled.
2022-04-18T18:21:05.728+0000 7fc931785700 -1 WARNING: all dangerous and experimental features are enabled.
Error EIO: Module 'selftest' has experienced an error and cannot handle commands: Synthetic exception in serve
2022-04-18 18:21:05,949.949 INFO:tasks.ceph_test_case:waiting 30s for health warning matching Module 'selftest' has failed: Synthetic exception in serve
2022-04-18 18:21:25,909.909 INFO:__main__:Stopped test: test_module_commands (tasks.mgr.test_module_selftest.TestModuleSelftest)
That module-handled commands have appropriate  behavior on in 67.935389s
2022-04-18 18:21:25,909.909 INFO:__main__:Starting test: test_module_remote (tasks.mgr.test_module_selftest.TestModuleSelftest)

vshankar
vshankar approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 25, 2022

@vshankar @epuertat Recent push consists of no code changes. I've modified the commit message that was marked DNM and removed a comment from vstart_runner.py since it isn't relevant anymore.

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 25, 2022

Removing DNM label now since the changes are final and Ceph API test didn't fail last couple of times.

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 26, 2022

jenkins test make check

@github-actions
Copy link

github-actions bot commented Apr 26, 2022

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

rishabh-d-dave
rishabh-d-dave commented Apr 27, 2022
View reviewed changes
doc/dev/developer_guide/running-tests-locally.rst Outdated
Comment on lines +106 to +109
commands with passwordless sudo access. A failure on the kernel
client may crash the host, so it's recommended to use this
functionality within a virtual machine.
commands with passwordless sudo access.

.. note:: A failure on the kernel client may crash the host, so it's
recommended to use this functionality within a virtual machine.
Copy link
Contributor Author

@rishabh-d-dave rishabh-d-dave Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes have been merged in a separate PR - #45923.

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 27, 2022

Rebased and resolved a conflict in qa/tasks/cephfs/mount.py.

@ljflores
Copy link
Member

ljflores commented Apr 27, 2022

@batrick does this PR look okay to you? I see you originally requested changes.

@github-actions
Copy link

github-actions bot commented May 2, 2022

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@vshankar
Copy link
Contributor

vshankar commented May 2, 2022

@batrick does this PR look okay to you? I see you originally requested changes.

@batrick is on PTO. I ran this through fs suite and results look fine to me. I plan to merge this soon (post reabse).

@rishabh-d-dave
qa/vstart_runner: accept multiple commands as str
27eaacd 
Convert all command arguments to str from list, update checks and
adjustments performed on command arguments accordingly and update
documentation to include warnings about some critical parts of
vstart_runner.py and update tasks.cephfs.mount.MountCephFS.run_shell().

Fixes: https://tracker.ceph.com/issues/47849
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
qa/vstart_runner: override adjust-ulimits, ceph-coverage & sudo
7d53423 
Overridding commands is much better than deleting these commands from
command argument string using Python since, unlike deleting, overridding
doesn't require parsing. A note has been added for this to
vstart_runner.py's module docstring and to Ceph Developer's Guide
document.

Since functions don't work with sh shell, to make overriding work
vstart_runner.py will use bash shell here onwards.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
qa/vstart_runner: copy few more note points from dev guide
8fc635c 
The intention behind copying these note points is to document the
behaviour of vstart_runner.py inside vstart_runner.py as well so that
developer don't miss it out while working on it.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
qa/vstart_runner: keep cmd args as passed by user as well
a67d500 
We convert all cmd args to str and pass bash functions along to override
certain arguments in those command arguments. Let's save cmd args
without those bash functions since they can be useful later (for
example, printing cmd args in logs, which is the case in this patch.)

Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
qa/vstart_runner: get rid of "exec sudo" from "ceph -w" cmd args
43b170a 
Passing "exec sudo" to "ceph -w" caused "Ceph API test" CI job to fail.
Error was not related to this tracker issue but the code added for it
is reversed now in this commit. The tracker issue -
https://tracker.ceph.com/issues/49644.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
qa/vstart_runner.py: add a note about omitting sudo
8d4ef76 
About the commit date: this commit got dropped from the patch series
during some PR branch update but is added back now.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
qa/vstart_runner: don't use os.kill for passing SIGKILL
f12536f 
vstart_runner.py is written assuming that it can run commands with
superuser privileges whenever possible and vstart_runner.py is meant to
be executed without sudo.

So, it's better kill a process using "sudo kill -9 <PID>", instead of
using os.kill() because os.kill() can't kill process launched with
superuser privileges.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
qa/vstart_runner: add a helper method to run commands
acc923c 
It's more convenient to not to pass stdout, stdin, and stderr every
single time.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
vshankar
vshankar approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Master#2022-May-04

@rishabh-d-dave rishabh-d-dave mentioned this pull request May 5, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lxbsz lxbsz lxbsz approved these changes

@vshankar vshankar vshankar approved these changes

@epuertat epuertat epuertat approved these changes

@batrick batrick Awaiting requested review from batrick

@tchaikov tchaikov Awaiting requested review from tchaikov

@ljflores ljflores Awaiting requested review from ljflores

Assignees

No one assigned

Labels

bug-fix build/ops cephfs Ceph File System documentation needs-qa tests vstart_runner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rishabh-d-dave @batrick @tchaikov @ljflores @vshankar @lxbsz @epuertat