mds: account for closing sessions in hit_session#37646
Merged
batrick merged 1 commit intoceph:masterfrom Oct 20, 2020
Merged
Conversation
While stopping an mds we can reply to a request while all client sessions are closing. We shouldn't assert in this case. Fixes: https://tracker.ceph.com/issues/47833 Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
Contributor
Author
|
I have tested and confirmed that this fixes the crash. |
Contributor
Author
batrick
approved these changes
Oct 13, 2020
Member
|
https://pulpito.ceph.com/?branch=wip-pdonnell-testing-20201013.174240 failures unrelated |
This was referenced Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While stopping an mds we can reply to a request while all client
sessions are closing. We shouldn't assert in this case.
Fixes: https://tracker.ceph.com/issues/47833
Signed-off-by: Dan van der Ster daniel.vanderster@cern.ch