mgr/cephadm: make j2 templates overwritable#37106
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Sep 22, 2020
Merged
mgr/cephadm: make j2 templates overwritable#37106sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
This adds an escape hatch, if the configs generated by cephadm are not flexible enough. Downside is obviously that future upgrades might break the daemons. Use at your own risk. Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Contributor
Author
p-se
approved these changes
Sep 15, 2020
Contributor
p-se
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
Contributor
|
Fixes: https://tracker.ceph.com/issues/47335 |
bk201
approved these changes
Sep 16, 2020
Contributor
bk201
left a comment
There was a problem hiding this comment.
Would it be better to add a prefix to the key names?
To overwrite template services/foo/bar.j2, currently it expects a store named mgr/cephadm/services_foo_bar. How about prefixing it to mgr/cephadm/custom_templates/services_foo_bar to avoid unexpected name conflict?
Contributor
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an escape hatch, if the configs generated
by cephadm are not flexible enough.
Downside is obviously that future upgrades might
break the daemons. Use at your own risk.
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
Fixes: https://tracker.ceph.com/issues/47335
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox