qa/tasks/cephadm.py: add ceph logs directory in job's info.yaml#36738
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Aug 25, 2020
Merged
qa/tasks/cephadm.py: add ceph logs directory in job's info.yaml#36738sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
This commit adds the file path of ceph log directories to the job's info.yaml log file. The motivation behind this is, in case of job timeout, the logs would still be tranferred to teuthology host before nuking test machines using these ceph log directory paths in job's info.yaml log file. Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
6 tasks
Contributor
Author
Contributor
tchaikov
reviewed
Aug 21, 2020
Contributor
|
just fyi, we have Line 157 in c8bfc66 |
jdurgin
approved these changes
Aug 23, 2020
Member
jdurgin
left a comment
There was a problem hiding this comment.
looks good, as you suggest we can extract to a separate function once the teuthology PR merges
tchaikov
approved these changes
Aug 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the file path of ceph log directories to the job's
info.yaml log file. The motivation behind this is, in case of job
timeout, the logs would still be tranferred to teuthology host
before nuking test machines using these ceph log directory paths in
job's info.yaml log file.
Signed-off-by: Shraddha Agrawal shraddha.agrawal000@gmail.com
related: #1546