Skip to content

dmclock: update submodule to fix hang on thread shutdown#36619

Merged
mattbenjamin merged 1 commit intoceph:masterfrom
cbodley:wip-46734
Sep 9, 2020
Merged

dmclock: update submodule to fix hang on thread shutdown#36619
mattbenjamin merged 1 commit intoceph:masterfrom
cbodley:wip-46734

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Aug 13, 2020

picks up the fix from ceph/dmclock#78

Fixes: https://tracker.ceph.com/issues/46734

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@cbodley cbodley requested a review from ivancich August 13, 2020 16:21
ivancich
ivancich approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@ivancich ivancich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did update the README.md file in the dmclock repo to provide a link for the new tracker for dmclock. Would you mind pulling that in as well?

@cbodley
Copy link
Contributor Author

cbodley commented Aug 13, 2020

repushed the submodule to match the latest dmclock master branch, which includes Update README.md to add link to tracker

@ivancich
Copy link
Member

ivancich commented Aug 13, 2020

Since dmclock is used in both core and rgw, I think it should run through both QA suites. I'll add the appropriate labels.

@ivancich
Copy link
Member

ivancich commented Aug 13, 2020 •
edited
Loading

repushed the submodule to match the latest dmclock master branch, which includes Update README.md to add link to tracker

Thank you, @cbodley .

@tchaikov
Copy link
Contributor

tchaikov commented Aug 21, 2020

@tchaikov
Copy link
Contributor

tchaikov commented Aug 29, 2020

@cbodley @ivancich could you include this change in your next batch?

@cbodley
Copy link
Contributor Author

cbodley commented Sep 3, 2020

https://pulpito.ceph.com/cbodley-2020-09-03_15:45:39-rgw-wip-cbodley-testing-distro-basic-smithi/

@cbodley
Copy link
Contributor Author

cbodley commented Sep 9, 2020

@tchaikov are you able to override the submodule check to merge this?

@mattbenjamin mattbenjamin merged commit ce1a1db into ceph:master Sep 9, 2020
@tchaikov
Copy link
Contributor

tchaikov commented Sep 10, 2020

@tchaikov are you able to override the submodule check to merge this?

ahh, already merged. let me know in case i could help next time.

@cbodley cbodley deleted the wip-46734 branch September 10, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivancich ivancich ivancich approved these changes

Assignees

No one assigned

Labels

bug-fix core needs-qa rgw wip-cbodley-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbodley @ivancich @tchaikov @mattbenjamin