mgr/cephadm: Make ceph orch * --refresh asynchronous#36447
Merged
sebastian-philipp merged 2 commits intoceph:masterfrom Aug 7, 2020
Merged
mgr/cephadm: Make ceph orch * --refresh asynchronous#36447sebastian-philipp merged 2 commits intoceph:masterfrom
ceph orch * --refresh asynchronous#36447sebastian-philipp merged 2 commits intoceph:masterfrom
Conversation
jschmid1
reviewed
Aug 4, 2020
| - add filtering by label | ||
| """ | ||
| if refresh: | ||
| # ugly sync path, FIXME someday perhaps? |
Contributor
There was a problem hiding this comment.
seems like someday is today 🎉
3f60d54 to
2dd9f94
Compare
mgfritch
approved these changes
Aug 4, 2020
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
this greatly improves the ux! 👍
Contributor
Author
2dd9f94 to
2b9ef4c
Compare
There is just no way we can allow those calls to be synchornous: * All CLI commands are blocked, till the refresh completes. * ^C doesn't help at all, as it just kills the client Therefore they have to be scheduled in the bg. Fixes: https://tracker.ceph.com/issues/46813 Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2b9ef4c to
be3f513
Compare
Contributor
|
jenkins test make check |
Contributor
Author
|
jenkins test make check |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is just no way we can allow those calls to be synchornous:
See https://docs.ceph.com/docs/master/dev/cephadm/#note-regarding-network-calls-from-cli-handlers for details
Therefore they have to be scheduled in the bg.
Fixes: https://tracker.ceph.com/issues/46813
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
This change affects ceph-linode and mgr/dashboard as well
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox