mgr/orchestrator: fix placement of '1' activating dry-run bug#36441
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Aug 4, 2020
Merged
mgr/orchestrator: fix placement of '1' activating dry-run bug#36441sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
mgfritch
approved these changes
Aug 3, 2020
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
for most of the commands the general order appears to be:
orch <command> <service_type> [placement] [dry-run] [format] [unmanaged]
lgtm!
when applying a placement of '1' for mon, mgr, rbd-mirror, crash, alertmanager, grafana, node-exporter, prometheus, or mds a dry-run was activated Fixes: https://tracker.ceph.com/issues/46819 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
451d530 to
9f7c8f7
Compare
jschmid1
approved these changes
Aug 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when applying a placement of '1' for mon, mgr, rbd-mirror, crash, alertmanager, grafana, node-exporter, prometheus, or mds a dry-run was activated
The '1' was being interpreted as 'true' for the dry-run flag, rearranging the order of flags makes the '1' interpreted as the placement.
Fixes: https://tracker.ceph.com/issues/46819
Signed-off-by: Daniel-Pivonka dpivonka@redhat.com