mgr/cephadm: track dependency in tox.ini#36407
Merged
tchaikov merged 1 commit intoceph:masterfrom Aug 3, 2020
Merged
Conversation
46ae55e to
a07dc7a
Compare
* track dependency for running tox tests with tox.ini. the fix test is not performed by "make check", so `install-deps.sh` is not responsible for preparing the autopep8 wheels. hence we can just put it in tox.ini * remove "python_version >= '3'" as we do not support python2 this change addresses a regression introduced by 7d8a3b6, which fails the rpmbuild like: RPM build errors: Installed (but unpackaged) file(s) found: /usr/share/ceph/mgr/requirements-fix.txt Signed-off-by: Kefu Chai <kchai@redhat.com>
a07dc7a to
a196672
Compare
sebastian-philipp
approved these changes
Aug 2, 2020
Contributor
|
Kefu, thank you for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox