mgr/cephadm: get_daemons_by_service should use dd.service_name#36388
Merged
sebastian-philipp merged 2 commits intoceph:masterfrom Aug 4, 2020
Merged
Conversation
daemon_name does not necessarily starts with the service_name. Especially not for OSDs. Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 tasks
jschmid1
approved these changes
Jul 31, 2020
Contributor
Author
|
This btw also relates to ceph/src/pybind/mgr/cephadm/module.py Line 1558 in 1bdf288 which also still uses ceph/src/pybind/mgr/orchestrator/_interface.py Lines 1308 to 1312 in 1bdf288 which is broken for OSDs: If you run |
mgfritch
approved these changes
Jul 31, 2020
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daemon_name does not necessarily starts with the service_name.
Especially not for OSDs. See #35945
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox