mgr/orchestrator: Update docstring of service_action method#36373
mgr/orchestrator: Update docstring of service_action method#36373sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
| :param service_name: service_type (e.g. "mds", "rgw", ...) + name of | ||
| logical service ("cephfs", "us-east", ...) |
There was a problem hiding this comment.
| :param service_name: service_type (e.g. "mds", "rgw", ...) + name of | |
| logical service ("cephfs", "us-east", ...) | |
| :param service_name: (e.g. "mon", "mgr", "mds.mycephfs", "rgw.realm.zone", ...) |
?
There was a problem hiding this comment.
I have modified it a bit.
437fae5 to
109ee5b
Compare
|
Hi I just wondered about your commit description "...n methods" and I though the commit title is so long that github won't show it because of "..." at the end ;) After clicking on the commit present with a view where title and message aren't shown as far apart it was clear to me that it should be displayed together. That said how about to shorten the message? How about: |
109ee5b to
daffec3
Compare
I have updated the commit title. |
|
jenkins retest this please |
| :param service_name: service_type + '.' + service_id | ||
| (e.g. "mon", "mgr", "mds.mycephfs", "rgw.realm.zone", ...) | ||
| :rtype: Completion |
There was a problem hiding this comment.
/home/jenkins-build/build/workspace/ceph-pr-docs/src/pybind/mgr/orchestrator/_interface.py:docstring of orchestrator.Orchestrator.service_action:8: WARNING: Field list ends without a blank line; unexpected unindent.
| :param daemon_id: Depending on daemon type it can be numerical value or | ||
| service name | ||
| :rtype: Completion |
There was a problem hiding this comment.
/home/jenkins-build/build/workspace/ceph-pr-docs/src/pybind/mgr/orchestrator/_interface.py:docstring of orchestrator.Orchestrator.daemon_action:9: WARNING: Field list ends without a blank line; unexpected unindent.
|
needs rebase |
daffec3 to
a397b6e
Compare
Signed-off-by: Varsha Rao <varao@redhat.com>
a397b6e to
4d6365b
Compare
Signed-off-by: Varsha Rao varao@redhat.com
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox