ceph-volume: dependency on python-ceph-common#36372
Merged
jan--f merged 1 commit intoceph:masterfrom Aug 5, 2020
Merged
Conversation
Contributor
Author
|
This also removes tox runs for python2 and fixes a unit test failure that only seems to occur on python3.8. |
Contributor
Author
|
jenkins test ceph-volume tox |
3 tasks
tchaikov
approved these changes
Aug 3, 2020
| Requires: lvm2 | ||
| Requires: sudo | ||
| Requires: libstoragemgmt | ||
| Requires: python%{python3_pkgversion}-ceph-common = %{_epoch_prefix}%{version}-%{release} |
Contributor
There was a problem hiding this comment.
note py-ceph-common is no longer py2 compatible. At least for master and octopus.
Also it is not yet backported to nautilus.
Contributor
Author
There was a problem hiding this comment.
Yep am aware. This is a follow up for the drive-groups subcommand and will only be backported to octopus.
Since e5b585d ceph-volume depends on python-ceph-common. This commit introduces this dependency for the ceph-osd rpm (which includes ceph-volume) and installs the dependency for tox runs. Fixes: https://tracker.ceph.com/issues/46772 Fixes: e5b585d Signed-off-by: Jan Fajerski <jfajerski@suse.com>
ad111c0 to
cb432fe
Compare
Contributor
Author
|
jenkins test ceph-volume tox |
rishabh-d-dave
approved these changes
Aug 5, 2020
guits
approved these changes
Aug 5, 2020
Contributor
guits
left a comment
There was a problem hiding this comment.
py2 testing error is irrelevant here
This was referenced Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since e5b585d ceph-volume depends on
python-ceph-common. This commit introduces this dependency for the
ceph-osd rpm (which includes ceph-volume) and installs the dependency
for tox runs.
Fixes: https://tracker.ceph.com/issues/46772
Fixes: e5b585d
Signed-off-by: Jan Fajerski jfajerski@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox