vstart: infer the mon public_network#36335
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Jul 30, 2020
Merged
Conversation
set the mon public_network when deploying with the cephadm flag Signed-off-by: Michael Fritch <mfritch@suse.com>
Contributor
Author
|
avoids the need to manually set the mon public_network after a vstart deployment. which is basically what Lines 2738 to 2740 in 4ba83be |
jschmid1
approved these changes
Jul 29, 2020
Contributor
Author
|
jenkins test dashboard backend |
| fi | ||
| if [ "$cephadm" -gt 0 ]; then | ||
| debug echo Setting mon public_network ... | ||
| public_network=$(ip route list | grep -w "$IP" | awk '{print $1}') |
Contributor
There was a problem hiding this comment.
This wont cover the ipv6 case, so will need to address that. my --ipv6 vstart PR still isn't landed so will go deal with it there :)
I'll go make a comment on it so I don't forget.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set the mon public_network when deploying with the cephadm flag
Signed-off-by: Michael Fritch mfritch@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox