librbd: use task finisher thread for image open/close callbacks#36287
Merged
trociny merged 1 commit intoceph:masterfrom Jul 28, 2020
Merged
librbd: use task finisher thread for image open/close callbacks#36287trociny merged 1 commit intoceph:masterfrom
trociny merged 1 commit intoceph:masterfrom
Conversation
Author
|
@ceph/api dashboard test failure |
There was a potential race condition with utilizing the AsioEngine to deliver asynchronous image open and close callbacks. This left the potential for the io_context thread to attempt to destroy itself. This commit changes the behavior of the image open and close callbacks to always delete the ImageCtx (now matches the synchronous API behavior) and it always invokes the callback in Finisher thread whose lifetime is tied to the CephContext. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
9bd9a1c to
90bd1d7
Compare
Author
|
Updated |
Author
|
jenkins test dashboard backend |
Contributor
|
this might fix https://tracker.ceph.com/issues/43274 ? |
Author
Negative -- but I haven't seen evidence of that bug appearing in a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a potential race condition with utilizing the AsioEngine
to deliver asynchronous image open and close callbacks. This left
the potential for the io_context thread to attempt to destroy itself.
This commit changes the behavior of the image open and close callbacks
to always delete the ImageCtx (now matches the synchronous API behavior)
and it always invokes the callback in Finisher thread whose lifetime is
tied to the CephContext.
Signed-off-by: Jason Dillaman dillaman@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox