mgr/orch: Add some more type annotations#36285
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Jul 28, 2020
Merged
Conversation
mgfritch
approved these changes
Jul 24, 2020
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
👍 for more type annotations! just a few minor nits ..
| else: | ||
| # must be idempotent: still a success. | ||
| return [f'Failed to remove service. <{service_name}> was not found.'] | ||
| return f'Failed to remove service. <{service_name}> was not found.' |
Contributor
There was a problem hiding this comment.
Suggested change
| return f'Failed to remove service. <{service_name}> was not found.' | |
| return f'Failed to remove service. {service_name} was not found.' |
output looks weird with <> chars? remove these?
Comment on lines
-792
to
+793
| # type: (HostSpec) -> Completion | ||
| # type: (HostSpec) -> Completion[str] |
Contributor
There was a problem hiding this comment.
convert these to py3 style while we are here?
Made `orch.Completion` a generic type Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
85d2c5c to
2310d7f
Compare
Contributor
Author
|
This PR conflicted with |
Contributor
Author
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made
orch.Completiona generic typeSigned-off-by: Sebastian Wagner sebastian.wagner@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox