mgr/cephadm: re-add apply_drivegroups()#36262
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Jul 28, 2020
Merged
Conversation
jschmid1
approved these changes
Jul 23, 2020
Contributor
jschmid1
left a comment
There was a problem hiding this comment.
+1, but let's add a NOTE that this is required by the dashboard and should not be renamed/removed.
Fixes: d348d7b Fixes: https://tracker.ceph.com/issues/46681 Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
077ed7c to
6e8f40e
Compare
bk201
approved these changes
Jul 23, 2020
Contributor
bk201
left a comment
There was a problem hiding this comment.
Thanks for bringing it back.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: d348d7b
Fixes: https://tracker.ceph.com/issues/46681
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
(as an alternative for #36254 )
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox