doc/cephadm: Fix typos in 'Cephadm Concepts' document.#36225
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Jul 23, 2020
Merged
doc/cephadm: Fix typos in 'Cephadm Concepts' document.#36225sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
Contributor
|
jenkins render docs |
Contributor
|
jenkins test make check |
Collaborator
|
Doc render available at http://docs.ceph.com/ceph-prs/36225/ |
varshar16
suggested changes
Jul 21, 2020
Contributor
varshar16
left a comment
There was a problem hiding this comment.
Commit title requires doc to be prefixed and it can be doc/cephadm: Fix typos. See https://docs.ceph.com/docs/master/start/documenting-ceph/#commit-the-change
mgfritch
approved these changes
Jul 21, 2020
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
lgtm after fixup of the commit title as suggested by @varshar16
Signed-off-by: Volker Theile <vtheile@suse.com>
e05b792 to
7f5244f
Compare
sebastian-philipp
approved these changes
Jul 22, 2020
Contributor
|
jenkins test make check |
varshar16
approved these changes
Jul 22, 2020
Contributor
|
jenkins test make check |
Contributor
Contributor
|
jenkins test make check |
1 similar comment
Contributor
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volker Theile vtheile@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox