cephadm: use src/mypy.ini instead#36217
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Jul 29, 2020
Merged
Conversation
mgfritch
reviewed
Jul 20, 2020
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
but I know that existing open PRs will fix a few issues.
fix is good, but will break make check on future PRs until we get these resolved.
which PR(s) address these? should they be addressed in this PR?
Contributor
Author
we can't merge this PR, till those issues are resolved.
I guess this PR :-) |
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
57c5d15 to
148ca82
Compare
2 tasks
Contributor
Author
jschmid1
approved these changes
Jul 29, 2020
jmolmo
reviewed
Jul 29, 2020
Member
jmolmo
left a comment
There was a problem hiding this comment.
Seems familiar to me.... :-) . LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
Right now, this fails with
but I know that existing open PRs will fix a few issues.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox