octopus: bluestore: Rescue procedure for extremely large bluefs log#36123
Merged
yuriw merged 3 commits intoceph:octopusfrom Aug 10, 2020
Merged
octopus: bluestore: Rescue procedure for extremely large bluefs log#36123yuriw merged 3 commits intoceph:octopusfrom
yuriw merged 3 commits intoceph:octopusfrom
Conversation
590ec51 to
4ff901d
Compare
This is a procedure tries to find on disk unreachable extents and pretend they were already a part of bluefs log. If this gives proper crc, accept it. Fixes: https://tracker.ceph.com/issues/46552 Signed-off-by: Adam Kupczyk <akupczyk@redhat.com> (cherry-picked from commit 40e94a1) Conflicts: src/os/bluestore/BlueFS.cc
This ability only makes sense as a step that allows to perform fsck before commiting recovered bluefs log. Fixes: https://tracker.ceph.com/issues/46552 Signed-off-by: Adam Kupczyk <akupczyk@redhat.com> (cherry-picked from commit 7b01af4) Conflicts: src/os/bluestore/BlueFS.cc
Adds additional paragraph to ceph-bluestore-tool documentation, describing how to use *special* options --bluefs_replay_recovery and --bluefs_replay_recovery_disable_compact to recover large bluefs log. Fixes: https://tracker.ceph.com/issues/46552 Signed-off-by: Adam Kupczyk <akupczyk@redhat.com> (cherry-picked from commit d7a49b0)
4ff901d to
c861dc1
Compare
smithfarm
previously requested changes
Jul 17, 2020
Contributor
smithfarm
left a comment
There was a problem hiding this comment.
Backport PR opened prematurely. The "cherry picked from commit ..." lines in the commit messages contain SHA1s that are not in master. If the master PR containing these commits - #36121 - gets rebased or force-pushed before it is merged, this PR will have to be redone.
Contributor
|
DNM until master PR merges and SHA1s are checked. |
Member
@smithfarm The master PR has now merged and SHA1s look right to me. |
smithfarm
approved these changes
Jul 25, 2020
neha-ojha
approved these changes
Jul 27, 2020
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/46599
backport of: #36121
parent tracker: https://tracker.ceph.com/issues/46552
Original PR description:
This is procedure that stems from https://tracker.ceph.com/issues/46195.
It was created and tested in Luminous, but now needs to be ported to all other ceph branches.
This one is a cherry-picked from
#36110#36121It fixes https://tracker.ceph.com/issues/46552