cephadm: fix usage of custom Prometheus image#35961
Merged
sebastian-philipp merged 3 commits intoceph:masterfrom Jul 20, 2020
Merged
cephadm: fix usage of custom Prometheus image#35961sebastian-philipp merged 3 commits intoceph:masterfrom
sebastian-philipp merged 3 commits intoceph:masterfrom
Conversation
sebastian-philipp
suggested changes
Jul 14, 2020
Fix the code by improving a condition where a zero as uid or gid leads to an additional attempt to extract the uid/gid instead of uid/gid simply being used correctly. Fixes: https://tracker.ceph.com/issues/46398 Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
18b9b37 to
8844ff4
Compare
sebastian-philipp
approved these changes
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/46398
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox