mgr/volumes/nfs: Reorder imports#35739
Merged
batrick merged 1 commit intoceph:masterfrom Jun 24, 2020
Merged
Conversation
tchaikov
reviewed
Jun 24, 2020
c7b7a1b to
398f08a
Compare
Contributor
|
to increase readability, I'd personally prefer to have the imports ordered by:
e.g. import errno
import json
import logging
from ceph.deployment.service_spec import NFSServiceSpec, PlacementSpec
from rados import TimedOut
import orchestrator
from .fs_util import create_pool |
This patch reorders import to fix "ImportError: cannot import name 'TimedOut'". As flake8 requires similar import types to be grouped together. Signed-off-by: Varsha Rao <varao@redhat.com>
398f08a to
c87050c
Compare
Contributor
Author
|
jenkins retest this please |
tchaikov
approved these changes
Jun 24, 2020
batrick
approved these changes
Jun 24, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes "ImportError: cannot import name 'TimedOut'"
Signed-off-by: Varsha Rao varao@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox