vstart: just use ganesha.nfsd that's in $PATH#35702
Merged
batrick merged 1 commit intoceph:masterfrom Jun 23, 2020
Merged
Conversation
In an earlier patch, I added a --ganesha-path option, but that left out ganesha-rados-grace, which also could be in an alternate path. Instead, just change vstart to run whatever ganesha.nfsd it finds in $PATH. We already do that for ganesha-rados-grace so it should be fine to do that for ganesha.nfsd as well. Signed-off-by: Jeff Layton <jlayton@redhat.com>
ajarr
approved these changes
Jun 22, 2020
varshar16
approved these changes
Jun 22, 2020
Contributor
varshar16
left a comment
There was a problem hiding this comment.
It looks good. Thanks Jeff.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an earlier patch, I added a --ganesha-path option, but that left out
ganesha-rados-grace, which also could be in an alternate path. Instead,
just change vstart to run whatever ganesha.nfsd it finds in $PATH. We
already do that for ganesha-rados-grace so it should be fine to do that
for ganesha.nfsd as well.
Signed-off-by: Jeff Layton jlayton@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox