Skip to content

qa,cmake: enable flake8 and import-tasks tests#35674

Merged
tchaikov merged 11 commits intoceph:masterfrom
tchaikov:wip-qa-tox
Jun 24, 2020
Merged

qa,cmake: enable flake8 and import-tasks tests#35674
tchaikov merged 11 commits intoceph:masterfrom
tchaikov:wip-qa-tox

Conversation

@tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Jun 19, 2020

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@tchaikov tchaikov requested a review from a team June 19, 2020 11:34
@tchaikov tchaikov requested a review from a team as a code owner June 19, 2020 11:34
@tchaikov tchaikov requested review from a team, jdurgin, neha-ojha and toabctl June 19, 2020 11:34
@tchaikov tchaikov requested a review from cbodley June 19, 2020 11:35
@tchaikov tchaikov added the rgw label Jun 19, 2020
kshtsk
kshtsk reviewed Jun 19, 2020
View reviewed changes
kshtsk
kshtsk reviewed Jun 19, 2020
View reviewed changes
@tchaikov
Copy link
Contributor Author

tchaikov commented Jun 19, 2020

@kshtsk fixed and repushed.

tchaikov
tchaikov commented Jun 19, 2020
View reviewed changes
varshar16
varshar16 reviewed Jun 19, 2020
View reviewed changes
@tchaikov
Copy link
Contributor Author

tchaikov commented Jun 19, 2020

jenkins test docs

@tchaikov tchaikov force-pushed the wip-qa-tox branch 4 times, most recently from b94b320 to b650a6f Compare June 20, 2020 02:50
tchaikov
tchaikov commented Jun 20, 2020
View reviewed changes
qa/tasks/cephfs/fuse_mount.py Outdated
break
except CommandFailedError:
if "Connection refused" in stderr.getvalue():
if "Connection refused" in p.stderr.getvalue():
Copy link
Contributor Author

@tchaikov tchaikov Jun 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug fix as well.

tchaikov
tchaikov commented Jun 20, 2020
View reviewed changes
qa/tasks/cephfs/test_openfiletable.py
"""

stat_out = self.fs.rados(["stat", "mds0_openfiles.1"])
self.fs.rados(["stat", "mds0_openfiles.1"])
Copy link
Contributor Author

@tchaikov tchaikov Jun 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vumrao could you help review this change?

@varshar16 varshar16 mentioned this pull request Jun 22, 2020
Merged
@batrick
Copy link
Member

batrick commented Jun 23, 2020

@tchaikov please rebase, the fuse_mount.py fix was merged in master yesterday

tchaikov added 10 commits June 23, 2020 23:00
@tchaikov
cmake: add TOX_ENVS keyword to test with listed test envs
a7beb90 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
qa: drop flake8-py2 test
c02748c 
as we've dropped py2 support, no need to run flake8 with python2
anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
qa/tasks: flake8 fixes
2fa726b 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
tasks/mgr/dashboard: flake8 fixes
0429096 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
qa/tasks/mgr/test_orchestrator_cli: flake8 fixes
2c2b5e0 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
qa/tasks/ragweed: flake8 fixes
fe6c9b5 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
qa/tasks/vstart_runner: flake8 fixes
663d64b 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
qa/standalone: flake8 fixes
48f0e02 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
qa/workunits/mon: flake8 fixes
fdcc3a8 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
qa/tasks/cephfs/test_nfs.py: flake8 fixes
981a7cc 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

tchaikov commented Jun 23, 2020

@batrick thanks for the reminder. rebased and repushed.

@tchaikov
qa/tasks/cephfs: flake8 fixes
21ad5bf 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

tchaikov commented Jun 24, 2020 

Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/../../src/script/gen_static_command_descriptions.py", line 168, in <module>
    print(json.dumps(gen_commands_dicts(), indent=2, sort_keys=True))
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/../../src/script/gen_static_command_descriptions.py", line 163, in gen_commands_dicts
    comms = from_mon_commands_h() + from_mgr_modules()
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/../../src/script/gen_static_command_descriptions.py", line 85, in from_mgr_modules
    comms = sum([list_mgr_module(name) for name in names], [])
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/../../src/script/gen_static_command_descriptions.py", line 85, in <listcomp>
    comms = sum([list_mgr_module(name) for name in names], [])
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/../../src/script/gen_static_command_descriptions.py", line 65, in list_mgr_module
    mgr_mod = __import__(m_name, globals(), locals(), [], 0)
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/src/pybind/mgr/volumes/__init__.py", line 2, in <module>
    from .module import Module
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/src/pybind/mgr/volumes/module.py", line 8, in <module>
    from .fs.nfs import NFSCluster, FSExport
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/src/pybind/mgr/volumes/fs/nfs.py", line 9, in <module>
    from rados import TimedOut
ImportError: cannot import name 'TimedOut'
Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/gen_mon_command_api.py", line 205, in <module>
    commands = json.loads(check_output([sys.executable, script_dir + '/../../src/script/gen_static_command_descriptions.py']))
  File "/usr/lib/python3.6/subprocess.py", line 356, in check_output
    **kwargs).stdout
  File "/usr/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/home/jenkins-build/build/workspace/ceph-pr-docs/build-doc/virtualenv/bin/python', '/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/../../src/script/gen_static_command_descriptions.py']' returned non-zero exit status 1.

@tchaikov
Copy link
Contributor Author

tchaikov commented Jun 24, 2020

jenkins test docs

@tchaikov
Copy link
Contributor Author

tchaikov commented Jun 24, 2020

@tchaikov tchaikov merged commit bd80490 into ceph:master Jun 24, 2020
@tchaikov tchaikov deleted the wip-qa-tox branch June 24, 2020 03:28
@varshar16 varshar16 mentioned this pull request Jun 24, 2020
Merged
@tchaikov tchaikov mentioned this pull request Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kshtsk kshtsk kshtsk approved these changes

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

@jdurgin jdurgin Awaiting requested review from jdurgin

@cbodley cbodley Awaiting requested review from cbodley

+3 more reviewers

@toabctl toabctl toabctl approved these changes

@Devp00l Devp00l Devp00l approved these changes

@varshar16 varshar16 varshar16 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cephfs Ceph File System dashboard needs-qa python3 rgw tests wip-kefu-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tchaikov @batrick @toabctl @kshtsk @Devp00l @varshar16