Skip to content

librbd: race when disabling object map with overlapping in-flight writes#35658

Merged
trociny merged 1 commit intoceph:masterfrom
dillaman:wip-46083
Jun 21, 2020
Merged

librbd: race when disabling object map with overlapping in-flight writes#35658
trociny merged 1 commit intoceph:masterfrom
dillaman:wip-46083

Conversation

@dillaman
Copy link

@dillaman dillaman commented Jun 18, 2020

The block guard that protects against overlapping updates to the object
map needs to be flushed prior to closing the object map instance.

Fixes: https://tracker.ceph.com/issues/46083
Signed-off-by: Jason Dillaman dillaman@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

trociny
trociny approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tchaikov
Copy link
Contributor

tchaikov commented Jun 19, 2020

jenkins test docs

1 similar comment
@tchaikov
Copy link
Contributor

tchaikov commented Jun 19, 2020

jenkins test docs

trociny
trociny reviewed Jun 20, 2020
View reviewed changes
@trociny
Copy link
Contributor

trociny commented Jun 20, 2020

And there was "qemu dynamic features" test failure, which is probably not related though. As I understand, one of xfs tests failed:

013      [failed, exit status 1] - output mismatch (see 013.out.bad)
    --- 013.out 2020-06-19 18:36:58.203838002 +0000
    +++ 013.out.bad     2020-06-19 18:37:22.335838002 +0000
    @@ -8,7 +8,6 @@
     -----------------------------------------------
     fsstress.2 : -p 20 -r
     -----------------------------------------------
    -
    ------------------------------------------------
    -fsstress.3 : -p 4 -z -f rmdir=10 -f link=10 -f creat=10 -f mkdir=10 -f rename=30 -f stat=30 -f unlink=30 -f truncate=20
    ------------------------------------------------
     ...
     (Run 'diff -u 013.out 013.out.bad' to see the entire diff)
_check_xfs_filesystem: filesystem on /dev/vdb has dirty log (see 013.full)
_check_xfs_filesystem: filesystem on /dev/vdb is inconsistent (c) (see 013.full)
_check_xfs_filesystem: filesystem on /dev/vdb is inconsistent (r) (see 013.full)
Ran: 001 002 003 004 005 006 007 009 011 012 013
Not run: 010
Failures: 013
Failed 1 of 11 tests

[1] http://qa-proxy.ceph.com/teuthology/trociny-2020-06-19_18:12:17-rbd-wip-mgolub-testing-1-distro-basic-smithi/5164885/teuthology.log

librbd: race when disabling object map with overlapping in-flight writes
ee69323 
The block guard that protects against overlapping updates to the object
map needs to be flushed prior to closing the object map instance.

Fixes: https://tracker.ceph.com/issues/46083
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@trociny trociny merged commit 89ad6c8 into ceph:master Jun 21, 2020
@smithfarm smithfarm mentioned this pull request Aug 15, 2020
Merged
@trociny trociny mentioned this pull request Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trociny trociny trociny approved these changes

Assignees

No one assigned

Labels

bug-fix needs-qa rbd wip-mgolub-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dillaman @tchaikov @trociny