stop.sh: do not block script when there is no running cluster#35637
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Jun 18, 2020
Merged
stop.sh: do not block script when there is no running cluster#35637sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
A query for current fsid is called inside `do_killcephadm`. This blocks the script when there is no running cluster. The fix avoids entering the function if cephadm command fails or returns no daemons. The change also hides the following output for non-cephadm environments: ``` Unable to locate any of ['podman', 'docker'] ``` Fixes: https://tracker.ceph.com/issues/46067 Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
varshar16
approved these changes
Jun 18, 2020
Contributor
|
jenkins test dashboard backend |
Contributor
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A query for current fsid is called inside
do_killcephadm. This blocksthe script when there is no running cluster. The fix avoids entering the
function if cephadm command fails or returns no daemons.
The change also hides the following output for non-cephadm environments:
Fixes: https://tracker.ceph.com/issues/46067
Signed-off-by: Kiefer Chang kiefer.chang@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox