cephadm: add sudo ssh user option#35606
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Jul 1, 2020
Merged
Conversation
mgfritch
reviewed
Jun 16, 2020
jmolmo
reviewed
Jun 17, 2020
sebastian-philipp
suggested changes
Jun 17, 2020
Contributor
|
can you please add |
9b5bc72 to
a920266
Compare
sebastian-philipp
approved these changes
Jun 19, 2020
5f24be7 to
713a385
Compare
Contributor
|
713a385 to
5f80a18
Compare
Author
|
not sure why i never got that error in my testing but should be fixed |
jmolmo
approved these changes
Jun 24, 2020
mgfritch
approved these changes
Jun 24, 2020
mgfritch
requested changes
Jun 25, 2020
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
tests are still failing:
http://pulpito.ceph.com/mgfritch-2020-06-24_23:08:15-rados-wip-mgfritch-testing-2020-06-24-1302-distro-basic-smithi/
2020-06-24T23:26:27.855 INFO:teuthology.orchestra.run.smithi198.stderr:INFO:cephadm:Wrote public SSH key to to /home/ubuntu/cephtest/ceph.pub
2020-06-24T23:26:27.855 INFO:teuthology.orchestra.run.smithi198.stderr:INFO:cephadm:Adding key to root@localhost's authorized_keys...
2020-06-24T23:26:27.857 INFO:teuthology.orchestra.run.smithi198.stderr:Traceback (most recent call last):
2020-06-24T23:26:27.858 INFO:teuthology.orchestra.run.smithi198.stderr: File "/home/ubuntu/cephtest/cephadm", line 4852, in <module>
2020-06-24T23:26:27.858 INFO:teuthology.orchestra.run.smithi198.stderr: r = args.func()
2020-06-24T23:26:27.858 INFO:teuthology.orchestra.run.smithi198.stderr: File "/home/ubuntu/cephtest/cephadm", line 1185, in _default_image
2020-06-24T23:26:27.858 INFO:teuthology.orchestra.run.smithi198.stderr: return func()
2020-06-24T23:26:27.858 INFO:teuthology.orchestra.run.smithi198.stderr: File "/home/ubuntu/cephtest/cephadm", line 2717, in command_bootstrap
2020-06-24T23:26:27.859 INFO:teuthology.orchestra.run.smithi198.stderr: with open(auth_keys_file, 'a') as f:
2020-06-24T23:26:27.859 INFO:teuthology.orchestra.run.smithi198.stderr:FileNotFoundError: [Errno 2] No such file or directory: '/root/.ssh/authorized_keys'
Contributor
|
@mgfritch if a test run fails, can you also remove the [needs-qa] label? otherwise someone else might schedule a new run with the old code |
5f80a18 to
438cf8e
Compare
438cf8e to
1d22b3b
Compare
1d22b3b to
6e33215
Compare
add the ability to use a non-root users for connecting to hosts, this user requires pass wordless sudo access useful for clusters that have root ssh access disabled Fixes: https://tracker.ceph.com/issues/44866 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
6e33215 to
1052b9d
Compare
Contributor
|
retest this please |
Contributor
|
jenkins test make check |
This was referenced Aug 18, 2020
|
@Daniel-Pivonka Hello |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add the ability to use a non-root users for connecting to hosts, this user requires pass wordless sudo access
useful for clusters that have root ssh access disabled
Fixes: https://tracker.ceph.com/issues/44866
Fixes: [https://tracker.ceph.com/issues/45653, https://tracker.ceph.com/issues/44866]
Signed-off-by: Daniel-Pivonka dpivonka@redhat.com