Details about tests to verify changes in dashboard port/protocol:

In all the tests, after cluster creation we have:

[root@ceph-node-00 ~]# firewall-cmd --list-all
...
  services: cockpit dhcpv6-client ssh
  ports: 
...

Dashboard (https using port 8900):

# cephadm bootstrap --mon-ip $mon_ip  --initial-dashboard-password admin --dashboard-port 8900
...
INFO:cephadm:Ceph Dashboard is now available at:

	     URL: https://ceph-node-00:8900/
	    User: admin
	Password: admin
...

[root@ceph-node-00 ~]# firewall-cmd --list-all
...
  services: ceph ceph-mon cockpit dhcpv6-client ssh
  ports: 3300/tcp 6789/tcp 9283/tcp 8900/tcp 9093/tcp 9094/tcp 3000/tcp 9100/tcp
...

Dashboard (http using port 8900):

# cephadm bootstrap --mon-ip $mon_ip  --initial-dashboard-password admin --dashboard-port 8901 --dashboard-ssl-disabled
...
  INFO:cephadm:Ceph Dashboard is now available at:

  	     URL: http://ceph-node-00:8901/
  	    User: admin
  	Password: admin
...

# firewall-cmd --list-all
...
  services: ceph ceph-mon cockpit dhcpv6-client ssh
  ports: 3300/tcp 6789/tcp 9283/tcp 8901/tcp 9093/tcp 9094/tcp 3000/tcp 9100/tcp
...

Note: Verified also cluster creation with firewald service not installed, and installed but not enabled or stopped.

Before reviewing this, can split this into multiple commits? Having dedicated commits just for moving code before doing any modifications is good habit.

Before reviewing this, can split this into multiple commits? Having dedicated commits just for moving code before doing any modifications is good habit.

This is only the part around the command_bootstrap. Split in several commits will take more time and possibly make more difficult everything ... I know that there are lot of lines, but basically, as you said this is "a code move" so probably not so difficult to review. Would you mind to launch integrations tests for this PR? ( when it would be possible)

Before reviewing this, can split this into multiple commits? Having dedicated commits just for moving code before doing any modifications is good habit.

This is only the part around the command_bootstrap. Split in several commits will take more time and possibly make more difficult everything ... I know that there are lot of lines, but basically, as you said this is "a code move" so probably not so difficult to review. Would you mind to launch integrations tests for this PR? ( when it would be possible)

I remember that @tchaikov insisted on splitting my 1-commit PRs this into different commits.

Before reviewing this, can split this into multiple commits? Having dedicated commits just for moving code before doing any modifications is good habit.

I was going to make a similar comment. Having multiple commits would make this easier to review ..