Make mempool assignment same after bufferlist rebuild#35584
Merged
tchaikov merged 1 commit intoceph:masterfrom Jun 20, 2020
Merged
Make mempool assignment same after bufferlist rebuild#35584tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
rzarzynski
reviewed
Jun 16, 2020
| { | ||
| unsigned pos = 0; | ||
| int mempool = _buffers.front().get_mempool(); | ||
| nb->reassign_to_mempool(mempool); |
Contributor
There was a problem hiding this comment.
Yeah, lacking this reassignment seems to be actually a bug. Could you please create a ticket on the tracker and put Fixes into the commit message?
Fixes: https://tracker.ceph.com/issues/46027 Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
dc81849 to
b3a6d18
Compare
jdurgin
approved these changes
Jun 16, 2020
rzarzynski
approved these changes
Jun 16, 2020
Contributor
Merged
This was referenced Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that c_str() should not lose mempool assignment if it was forced to rebuild underlying buffer::raw structure.
Tracked by https://tracker.ceph.com/issues/46027