Skip to content

mgr/cephadm: document pool requirement for NFS-Ganesha service#35581

Merged
sebastian-philipp merged 1 commit intoceph:masterfrom
bk201:ganesha-doc-pool-existence
Jun 17, 2020
Merged

mgr/cephadm: document pool requirement for NFS-Ganesha service#35581
sebastian-philipp merged 1 commit intoceph:masterfrom
bk201:ganesha-doc-pool-existence

Conversation

@bk201
Copy link
Contributor

@bk201 bk201 commented Jun 16, 2020

Add a note in the document to remind users.

Signed-off-by: Kiefer Chang kiefer.chang@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@bk201 bk201 requested a review from a team as a code owner June 16, 2020 04:19
Copy link
Contributor

@varshar16 varshar16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have missed adding doc prefix in commit title. Please change it to doc/cephadm: Add pool requirement note for NFS-Ganesha service. Otherwise looks good.

@bk201 bk201 force-pushed the ganesha-doc-pool-existence branch from 6682f91 to fa38177 Compare June 16, 2020 05:31
@bk201
Copy link
Contributor Author

bk201 commented Jun 16, 2020

You have missed adding doc prefix in commit title. Please change it to doc/cephadm: Add pool requirement note for NFS-Ganesha service. Otherwise looks good.

Thanks! Fixed.

@bk201
Copy link
Contributor Author

bk201 commented Jun 16, 2020

jenkins render docs

@ceph-jenkins
Copy link
Collaborator

Doc render available at http://docs.ceph.com/ceph-prs/35581/

Copy link
Contributor

@asettle asettle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a suggestion

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
@bk201 bk201 force-pushed the ganesha-doc-pool-existence branch from fa38177 to 71140f4 Compare June 16, 2020 10:23
@sebastian-philipp sebastian-philipp merged commit 7e0b165 into ceph:master Jun 17, 2020
@bk201 bk201 deleted the ganesha-doc-pool-existence branch July 10, 2020 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants