Skip to content

cephadm: skip any invalid fsid(s) during infer#35578

Merged
sebastian-philipp merged 2 commits intoceph:masterfrom
mgfritch:cephadm-infer-fsid-ukn
Jun 17, 2020
Merged

cephadm: skip any invalid fsid(s) during infer#35578
sebastian-philipp merged 2 commits intoceph:masterfrom
mgfritch:cephadm-infer-fsid-ukn

Conversation

@mgfritch
Copy link
Contributor

Fixes: https://tracker.ceph.com/issues/45999
Signed-off-by: Michael Fritch mfritch@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

mgfritch added 2 commits June 15, 2020 15:22
$ cephadm shell
ERROR: Cannot infer an fsid, one must be specified: ['1d5df33f-eb94-4a4f-b192-1d5e770ed0e7', 'unknown']
$ cephadm shell
ERROR: Cannot infer an fsid, one must be specified: ['unknown', '1d5df33f-eb94-4a4f-b192-1d5e770ed0e7']

Signed-off-by: Michael Fritch <mfritch@suse.com>
Fixes: https://tracker.ceph.com/issues/45999
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch mgfritch requested a review from a team as a code owner June 15, 2020 21:24
@sebastian-philipp
Copy link
Contributor

Do you see an easy way to add a test for this?

@sebastian-philipp sebastian-philipp merged commit 9df7e03 into ceph:master Jun 17, 2020
@mgfritch mgfritch deleted the cephadm-infer-fsid-ukn branch June 18, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants