Skip to content

cephadm: call podman rm --storage#35524

Merged
tchaikov merged 1 commit intoceph:masterfrom
sebastian-philipp:cephadm-rm-container-storage
Jun 16, 2020
Merged

cephadm: call podman rm --storage#35524
tchaikov merged 1 commit intoceph:masterfrom
sebastian-philipp:cephadm-rm-container-storage

Conversation

@sebastian-philipp
Copy link
Contributor

@sebastian-philipp sebastian-philipp commented Jun 10, 2020

Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com

This should fix

systemd[1]: ceph-36889d04-a982-11ea-a06d-001a4aab830c@mon.b.service holdoff time over, scheduling restart.
systemd[1]: Stopped Ceph mon.b for 36889d04-a982-11ea-a06d-001a4aab830c.
systemd[1]: Starting Ceph mon.b for 36889d04-a982-11ea-a06d-001a4aab830c...
podman[9425]: Error: no container with name or ID ceph-36889d04-a982-11ea-a06d-001a4aab830c-mon.b found: no such container
systemd[1]: Started Ceph mon.b for 36889d04-a982-11ea-a06d-001a4aab830c.
bash[9449]: Error: no container with name or ID ceph-36889d04-a982-11ea-a06d-001a4aab830c-mon.b found: no such container
bash[9449]: Error: error creating container storage: the container name "ceph-36889d04-a982-11ea-a06d-001a4aab830c-mon.b" is already in use by "f265ae83cb9ed32b7ed6fd6e62a2e764549
systemd[1]: ceph-36889d04-a982-11ea-a06d-001a4aab830c@mon.b.service: main process exited, code=exited, status=125/n/a
podman[9489]: Error: no container with name or ID ceph-36889d04-a982-11ea-a06d-001a4aab830c-mon.b found: no such container
systemd[1]: Unit ceph-36889d04-a982-11ea-a06d-001a4aab830c@mon.b.service entered failed state.
systemd[1]: ceph-36889d04-a982-11ea-a06d-001a4aab830c@mon.b.service failed.

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@sebastian-philipp sebastian-philipp requested a review from a team as a code owner June 10, 2020 12:29
mgfritch
mgfritch reviewed Jun 10, 2020
View reviewed changes
Copy link
Contributor

@mgfritch mgfritch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err but this is podman only, the --storage option does not exist for docker ....

https://docs.docker.com/engine/reference/commandline/rm/

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jun 10, 2020

err but this is podman only, the --storage option does not exist for docker ....

https://docs.docker.com/engine/reference/commandline/rm/

yes, that's why I've added if 'podman' in container_path:

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jun 10, 2020

getting increasingly unhappy with this approach, but I'd like to move forward with those QA failures.

@mgfritch
Copy link
Contributor

mgfritch commented Jun 10, 2020 •
edited
Loading

err but this is podman only, the --storage option does not exist for docker ....
https://docs.docker.com/engine/reference/commandline/rm/

yes, that's why I've added if 'podman' in container_path:

oops, I missed that. still somewhat curious the force -f option didn't cover that case...

getting increasingly unhappy with this approach, but I'd like to move forward with those QA failures.

maybe we should try upgrading the test harness to eliminate any podman bugs as suggested by @tchaikov (#35018 (comment)) ?

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jun 12, 2020

green: http://pulpito.ceph.com/swagner-2020-06-11_14:15:42-rados:cephadm-wip-swagner-testing-2020-06-11-1428-distro-basic-smithi/

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jun 12, 2020

`cephadm:2218: error: Type signature has too few arguments

@sebastian-philipp
cephadm: call podman rm --storage
decfbca 
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp sebastian-philipp force-pushed the cephadm-rm-container-storage branch from de26d64 to decfbca Compare June 15, 2020 08:55
@tchaikov tchaikov merged commit db7ae7c into ceph:master Jun 16, 2020
@sebastian-philipp sebastian-philipp mentioned this pull request Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgfritch mgfritch mgfritch left review comments

@tchaikov tchaikov tchaikov approved these changes

Assignees

No one assigned

Labels

cephadm needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebastian-philipp @mgfritch @tchaikov