stop.sh: Kill cephadm deployed daemons#35472
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Jun 15, 2020
Merged
Conversation
0c94d60 to
5926f77
Compare
sebastian-philipp
approved these changes
Jun 11, 2020
Contributor
sebastian-philipp
left a comment
There was a problem hiding this comment.
I think you're fixing https://tracker.ceph.com/issues/44746 here.
sebastian-philipp
suggested changes
Jun 11, 2020
Contributor
There was a problem hiding this comment.
Getting
➜ build git:(upstream-pull-35472) ✗ ../src/stop.sh ; finished
ERROR: cephadm should be run as root
ERROR: cephadm should be run as root
➜ cephadm git:(upstream-pull-35472) ✗ sudo ./cephadm ls
[
{
"style": "cephadm:v1",
"name": "crash.ubuntu",
"fsid": "5f5a6f60-35dd-4ef2-b3e1-73a4ddc057a0",
"systemd_unit": "ceph-5f5a6f60-35dd-4ef2-b3e1-73a4ddc057a0@crash.ubuntu",
"enabled": true,
"state": "running",
"container_id": "51101f158c73a5c0281dba83fb1eb086551c9cf93ebc8c3d9dda14e3454fe041",
"container_image_name": "docker.io/ceph/daemon-base:latest-master-devel",
"container_image_id": "74803e884bea289d2d2d3ebdf6d37cd560499e955595695b1390a89800f4e37a",
"version": "16.0.0-901-g713ef3c",
"started": "2020-06-11T12:38:17.310159",
"created": "2020-06-11T12:38:17.117573",
"deployed": "2020-06-11T12:38:16.405570",
"configured": "2020-06-11T12:38:17.117573"
}
]
Fixes: https://tracker.ceph.com/issues/44746 Signed-off-by: Varsha Rao <varao@redhat.com>
5926f77 to
4930dc7
Compare
Contributor
Author
Fixed. |
Contributor
Author
Yes, I have added the tracker ticket in the commit message. |
sebastian-philipp
approved these changes
Jun 15, 2020
| CEPH_CONF_PATH="$PWD" | ||
| fi | ||
| conf_fn="$CEPH_CONF_PATH/ceph.conf" | ||
| CEPHADM_DIR_PATH="$CEPH_CONF_PATH/../src/cephadm" |
Contributor
There was a problem hiding this comment.
This is going to make it even more complicated to have anything but one big cephadm script without any form of packaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds call to cephadm vstart-cleanup script to remove daemons.
Signed-off-by: Varsha Rao varao@redhat.com
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox