qa/cephadm: Docker doesn't ship a registries.conf#35273
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom May 27, 2020
Merged
qa/cephadm: Docker doesn't ship a registries.conf#35273sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
I guess not using the mirror for docker based tests is ok for now. For adding docker support, we need to: 1. change the docker config 2. restart the docker daemon Note that Docker's config only supports to mirror the docker.io registry. Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
This was referenced May 27, 2020
Contributor
|
jenkins retest this please |
kshtsk
reviewed
May 27, 2020
| ) | ||
| except FileNotFoundError as e: | ||
| # Docker doesn't ship a registries.conf | ||
| log.info('Failed to add mirror: %s' % str(e)) |
Contributor
There was a problem hiding this comment.
Isn't it an error and we should stop testing now?
Contributor
Author
There was a problem hiding this comment.
if the file isn't there, we can simply fall back to the default config and download from docker.io
worst case is: the ubuntu based tests fail. And at that point, we have to also look into the things I stated in the PR description
Contributor
There was a problem hiding this comment.
I understand you guys are in a rush that you merged it. But since you were trying to override the non-existing file, it is definitely an error, at least, you might want to use log.warning... ;-) otherwise I don't see a reason to inform user that is missing anyways.
PS: The PR description does not say much to me.
tchaikov
approved these changes
May 27, 2020
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess not using the mirror for docker based tests is ok for now.
For adding docker support, we need to:
Note that Docker's config only supports to mirror the docker.io registry.
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox