doc: New section in device management by jmolmo · Pull Request #35124 · ceph/ceph

jmolmo · 2020-05-19T10:10:55Z

A new section to describe the command used to blink lights in physical devices

Signed-off-by: Juan Miguel Olmo Martínez jolmomar@redhat.com

-->

Checklist

References tracker ticket
Updates documentation if necessary
Includes tests for new functionality or reproducer for bug

jenkins test docs
jenkins render docs

sebastian-philipp · 2020-05-19T13:52:27Z

hm. this is a bit misleading, as this depends on (and is actually par of) the orchestrator.

I'm torn. On one hand, this is not part of ceph orch, but on the other hand, we really need to make people aware that this this depends on the orchestrator (i.e. either cephadm or rook)

tchaikov · 2020-05-20T04:20:27Z

doc/rados/operations/devices.rst

+
+  ceph device ls
+
+The second parameter sets the kind of light to blink.  By default the


Suggested change

The second parameter sets the kind of light to blink. By default the

The second parameter of ``device light on|off`` command sets the kind of light to blink. By default the

as otherwise, reader (me, for instance) might want to search backwards for the command and the "second parameter". and the first match would be "ceph device ls".

Changed. @tchaikov, what do you think now?

tchaikov · 2020-05-20T04:23:42Z

doc/rados/operations/devices.rst

+You can blink lights on hardware enclosures to make the replacement of failed
+disks easy and less error-prone.  Use the following command::


Suggested change

You can blink lights on hardware enclosures to make the replacement of failed

disks easy and less error-prone. Use the following command::

You can blink the drive LEDs on hardware enclosures to identify the failed disk drive prior to replacement. Use the following command::

@zdover23 what do you think?

jmolmo · 2020-05-20T09:26:31Z

hm. this is a bit misleading, as this depends on (and is actually par of) the orchestrator.

I'm torn. On one hand, this is not part of ceph orch, but on the other hand, we really need to make people aware that this this depends on the orchestrator (i.e. either cephadm or rook)

@sebastian-philipp : We have two options:

a) Leave this functionality "inside" the "ceph device" commands set. This is my preferred , because I think that it is more easy for the user to have all the things around devices in the "same place". (despite we have this dependency)... after all, we will finish installing all the clusters using cephadm or rook...and therefore we will have the orch module enabled by default.

b) Move this command to the orchestrator command set:
ceph orch device light ....
In this case, i think that the user needs to know that this functionality is inside the orchestrator command set. I think seems less natural... but we avoid the dependency

I have added a note to outline this dependency, i think probably it is enough.

jmolmo · 2020-05-25T06:32:25Z

@tchaikov are you ok with the changes?

tchaikov

@jmolmo LGTM. just two nits. sorry for the latency. just saw your comment.

tchaikov · 2020-05-25T08:33:29Z

doc/rados/operations/devices.rst

+
+  device light on|off <devid> [ident|fault] [--force]
+
+The <devid> parameter is the device identification, and you can obtain this


Suggested change

The <devid> parameter is the device identification, and you can obtain this

The ``<devid>`` parameter is the device identification, and you can obtain this

doc/rados/operations/devices.rst

tchaikov · 2020-05-27T12:35:01Z

/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/smoke.sh:56: TEST_multimon:  timeout 8 rados -p foo bench 4 write -b 4096 --no-cleanup
hints = 1
Maintaining 16 concurrent writes of 4096 bytes to objects of size 4096 for up to 4 seconds or 0 objects
Object prefix: benchmark_data_slave-ubuntu11_11219
  sec Cur ops   started  finished  avg MB/s  cur MB/s last lat(s)  avg lat(s)
    0      16        16         0         0         0           -           0
    1      16        16         0         0         0           -           0
    2      16        16         0         0         0           -           0
    3      16        33        17 0.0220724 0.0221354    0.521384     2.28468
    4      16        33        17 0.0165655         0           -     2.28468
    5      16        33        17 0.0132578         0           -     2.28468
Total time run:         5.88443
Total writes made:      33
Write size:             4096
Object size:            4096
Bandwidth (MB/sec):     0.0219063
Stddev Bandwidth:       0.00989926
Max bandwidth (MB/sec): 0.0221354
Min bandwidth (MB/sec): 0
Average IOPS:           5
Stddev IOPS:            2.23607
Max IOPS:               5
Min IOPS:               0
Average Latency(s):     2.81336
Stddev Latency(s):      0.644136
Max latency(s):         3.40527
Min latency(s):         0.521384
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/smoke.sh:56: TEST_multimon:  return 1

tchaikov · 2020-05-27T12:35:28Z

jenkins test make check

A new section to describe the command used to blink lights in physical devices Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>

tchaikov · 2020-05-27T14:47:12Z

[ RUN      ] TestDeepCopy.Snaps_LargerDstObjSize
creating image with stripe unit: 2097152, stripe count: 16
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/librbd/test_DeepCopy.cc:117: Failure
Expected equality of these values:
  read_size
    Which is: 4194304
  api::Io<>::read( *m_dst_ictx, offset, read_size, librbd::io::ReadResult{dst_result}, 0)
    Which is: 2097152
[  FAILED  ] TestDeepCopy.Snaps_LargerDstObjSize (417 ms)

@dillaman seems it's a new test failure. i filed a tracker ticket at https://tracker.ceph.com/issues/45731

tchaikov · 2020-06-02T04:48:48Z

jenkins test make check

jmolmo added documentation orchestrator labels May 19, 2020

jmolmo requested a review from a team May 19, 2020 10:10

tchaikov reviewed May 20, 2020

View reviewed changes

ceph deleted a comment from rzarzynski May 20, 2020

jmolmo force-pushed the wip-doc-update-devices branch from 81e4a78 to 6c63f29 Compare May 20, 2020 09:13

jmolmo requested a review from tchaikov May 20, 2020 09:28

sebastian-philipp approved these changes May 20, 2020

View reviewed changes

tchaikov approved these changes May 25, 2020

View reviewed changes

jmolmo force-pushed the wip-doc-update-devices branch from 6c63f29 to 72e92f4 Compare May 27, 2020 08:57

sebastian-philipp requested a review from asettle May 27, 2020 10:52

asettle requested changes May 27, 2020

View reviewed changes

doc/rados/operations/devices.rst Outdated Show resolved Hide resolved

doc/rados/operations/devices.rst Outdated Show resolved Hide resolved

doc/rados/operations/devices.rst Outdated Show resolved Hide resolved

doc/rados/operations/devices.rst Outdated Show resolved Hide resolved

doc: New section in device management

e025727

A new section to describe the command used to blink lights in physical devices Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>

jmolmo force-pushed the wip-doc-update-devices branch from 72e92f4 to e025727 Compare May 27, 2020 13:42

sebastian-philipp merged commit cdec26d into ceph:master Jun 2, 2020

sebastian-philipp mentioned this pull request Jun 2, 2020

octopus: cephadm: batch backport June (1) #35347

Merged


		ceph device ls

		The second parameter sets the kind of light to blink. By default the

	The second parameter sets the kind of light to blink. By default the
	The second parameter of ``device light on\|off`` command sets the kind of light to blink. By default the

		You can blink lights on hardware enclosures to make the replacement of failed
		disks easy and less error-prone. Use the following command::

	You can blink lights on hardware enclosures to make the replacement of failed
	disks easy and less error-prone. Use the following command::
	You can blink the drive LEDs on hardware enclosures to identify the failed disk drive prior to replacement. Use the following command::


		device light on\|off <devid> [ident\|fault] [--force]

		The <devid> parameter is the device identification, and you can obtain this

	The <devid> parameter is the device identification, and you can obtain this
	The ``<devid>`` parameter is the device identification, and you can obtain this

Conversation

jmolmo commented May 19, 2020

Checklist

Uh oh!

sebastian-philipp commented May 19, 2020

Uh oh!

tchaikov May 20, 2020

Choose a reason for hiding this comment

Uh oh!

jmolmo May 20, 2020

Choose a reason for hiding this comment

Uh oh!

tchaikov May 20, 2020

Choose a reason for hiding this comment

Uh oh!

jmolmo May 20, 2020

Choose a reason for hiding this comment

Uh oh!

jmolmo commented May 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmolmo commented May 25, 2020

Uh oh!

tchaikov left a comment

Choose a reason for hiding this comment

Uh oh!

tchaikov May 25, 2020

Choose a reason for hiding this comment

Uh oh!

jmolmo May 27, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchaikov commented May 27, 2020

Uh oh!

tchaikov commented May 27, 2020

Uh oh!

tchaikov commented May 27, 2020

Uh oh!

tchaikov commented Jun 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmolmo commented May 20, 2020 •

edited

Loading