mgr/cephadm: allow custom images for grafana, prometheus, alertmanager and node_exporter#35106
Merged
sebastian-philipp merged 6 commits intoceph:masterfrom May 27, 2020
Conversation
Contributor
Author
|
If that turns out to be the right approach for being able to specify and use custom images, I'd also like to add a documentation update on how to use it. |
sebastian-philipp
approved these changes
May 18, 2020
mgfritch
reviewed
May 18, 2020
Contributor
|
@p-se needs rebase |
0f6cb1f to
8442400
Compare
Namely, - Grafana - Prometheus - Alertmanager and - Node exporter. Fixes: https://tracker.ceph.com/issues/45463 Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
8442400 to
7ca3b47
Compare
7 tasks
| reconfig=False, | ||
| osd_uuid_map=None) -> str: | ||
| osd_uuid_map: Optional[Dict[str, Any]] = None, | ||
| redeploy=False, |
Contributor
There was a problem hiding this comment.
Sigh. this PR introduced an unused redeploy parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/45463
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox