qa/cephadm: Add roleless mon names to ctx.cluster.remotes role dict#35104
Merged
tchaikov merged 1 commit intoceph:masterfrom May 22, 2020
Merged
qa/cephadm: Add roleless mon names to ctx.cluster.remotes role dict#35104tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
sebastian-philipp
approved these changes
May 18, 2020
Contributor
|
It should fix the issue but maybe better use |
3 tasks
Fixes: https://tracker.ceph.com/issues/45584 Signed-off-by: Varsha Rao <varao@redhat.com>
f8d706f to
58eaeb5
Compare
Contributor
Author
|
Rebased |
Contributor
Author
We cannot use diff --git a/qa/tasks/cephadm.py b/qa/tasks/cephadm.py
index 1ffd02553d..c3ee263b77 100644
--- a/qa/tasks/cephadm.py
+++ b/qa/tasks/cephadm.py
@@ -1031,16 +1031,14 @@ def task(ctx, config):
if config.get('roleless', False):
# mons will be named after hosts
- n = len(roles)
- roles = []
first_mon = None
- for remote, _ in remotes_and_roles:
- roles.append(['mon.' + remote.shortname])
+ for remote, role in remotes_and_roles:
+ role.append('mon.' + remote.shortname)
if not first_mon:
first_mon = remote.shortname
bootstrap_remote = remote
- log.info('No roles; fabricating mons %s' % roles)
-
+ log.info('No mon roles; fabricating mons')
+
ctx.ceph[cluster_name].mons = get_mons(
roles, ips, cluster_name,
mon_bind_msgr2=config.get('mon_bind_msgr2', True), |
Contributor
|
the failures are either tracked or fixed by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/45584
Signed-off-by: Varsha Rao varao@redhat.com
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox