cephadm: Make ceph-iscsi api user and password mandatory#35097
Merged
tchaikov merged 1 commit intoceph:masterfrom May 27, 2020
Merged
cephadm: Make ceph-iscsi api user and password mandatory#35097tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
9bfae5f to
b75a5fd
Compare
Contributor
Author
|
Just corrected commit message |
Contributor
|
The api user and password is required in order to use the API so let's make these mandatory. The `ceph orch daemon add iscsi` now has them mandatory: ceph orch daemon add iscsi <pool> <api_user> <api_password> If your using apply with a yaml file, the validate_add in the spec now checks for these too. Signed-off-by: Matthew Oliver <moliver@suse.com>
b75a5fd to
a36165b
Compare
Contributor
Author
|
Opps, sorry, pushed the code up last night and forgot about the tests that weren't added and amended to this patch so didn't go up with it. |
Contributor
mgfritch
approved these changes
May 21, 2020
Comment on lines
+609
to
+614
| if not self.api_user: | ||
| raise ServiceSpecValidationError( | ||
| 'Cannot add ISCSI: No Api user specified') | ||
| if not self.api_password: | ||
| raise ServiceSpecValidationError( | ||
| 'Cannot add ISCSI: No Api password specified') |
Contributor
There was a problem hiding this comment.
this is going to get interesting if we're making an upgrade and users already have an iscsi service applied without user / password.
Is there a super easy way to resolve this?
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The api user and password is required in order to use the API so let's
make these mandatory. The
ceph orch daemon add iscsinow has themmandatory:
ceph orch daemon add iscsi <api_user> <api_password>
If your using apply with a yaml file, the validate in the spec now
checks for these too.
Signed-off-by: Matthew Oliver moliver@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox