[doc/install]: Add note warning against the :latest tag.#35006
[doc/install]: Add note warning against the :latest tag.#35006sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
mgfritch
left a comment
There was a problem hiding this comment.
Maybe we should also add an example of an explicit tag?
docker pull ceph/ceph:v15.2.0
6b6490d to
07db2e6
Compare
| Ceph Container Images | ||
| ===================== |
There was a problem hiding this comment.
we somehow have to make cephadm users aware of it, as they typically will not look into install/containers.
What about simply moving this file to doc/cephadm?
There was a problem hiding this comment.
@sebastian-philipp Is it your vote that we move all of the content in containers.rst over to doc/cephadm?
There was a problem hiding this comment.
wdyt? Either we link it from cephadm, or we move it there.
There was a problem hiding this comment.
I've been sitting here chewing my lip and thinking about it, and I think I'm just going to add a link on the cephadm page. If after a few days we don't think that that's sufficient, I'll move the matter in this page to the cephadm page. (The cephadm page has bigger problems at the moment, in my opinion, anyway.)
There was a problem hiding this comment.
2 cents I wasn't pinged for, I agree with @zdover23 - a cross ref should be fine in this instance. A short sentence and "here's where to go". If there's complaints later, that can be rectified.
|
jenkins test make check |
|
ping? |
95f6b2c to
b8a3de1
Compare
|
lgtm. Squashing the commits would be great! |
Signed-off-by: Zac Dover <zac.dover@gmail.com> Incorporating mgfritch's improvements. Signed-off-by: Zac Dover <zac.dover@gmail.com> s/docker/podman/ -- as per mgfritch's suggestion Signed-off-by: Zac Dover <zac.dover@gmail.com> s/: latest/:latest/ Signed-off-by: Zac Dover <zac.dover@gmail.com> s/image ids/image IDs/ -- as per Alex Settle's suggestion. Signed-off-by: Zac Dover <zac.dover@gmail.com> Add note warning against the :latest tag. Signed-off-by: Zac Dover <zac.dover@gmail.com> s/image ids/image IDs/ -- as per Alex Settle's suggestion. Signed-off-by: Zac Dover <zac.dover@gmail.com> Linked to container page from cephadm install page. Signed-off-by: Zac Dover <zac.dover@gmail.com> Clarified the note directing readers to the container documentation. Signed-off-by: Zac Dover <zac.dover@gmail.com>
b4f3ed4 to
f0fe087
Compare
|
God willing, this thing is rebased against master and properly squashed. |
Signed-off-by: Zac Dover zac.dover@gmail.com
This commit adds a warning against using the ": latest" tag in dockerfiles. Doing so can result in an inconsistent environment.
Fixes: https://tracker.ceph.com/issues/45411
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox