Skip to content

mgr/dashboard: document Prometheus' security model#34902

Merged
sebastian-philipp merged 1 commit intoceph:masterfrom
p-se:wip-pse-doc-prom-security
May 27, 2020
Merged

mgr/dashboard: document Prometheus' security model#34902
sebastian-philipp merged 1 commit intoceph:masterfrom
p-se:wip-pse-doc-prom-security

Conversation

@p-se
Copy link
Contributor

@p-se p-se commented May 5, 2020 •
edited by votdev
Loading

Fixes: https://tracker.ceph.com/issues/45377

Signed-off-by: Patrick Seidensal pseidensal@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@p-se p-se requested review from LenzGr and l-mb May 5, 2020 12:22
LenzGr
LenzGr reviewed May 5, 2020
View reviewed changes
LenzGr
LenzGr reviewed May 5, 2020
View reviewed changes
@LenzGr
Copy link
Contributor

LenzGr commented May 5, 2020

LGTM, I left a few small enhancement suggestions. Since this chapter is about Grafana dashboards, it's somewhat irritating to begin it with a warning about Prometheus without giving some context about its role in this scenario.

@p-se p-se force-pushed the wip-pse-doc-prom-security branch from 988aeac to 096b222 Compare May 6, 2020 07:18
@s0nea
Copy link
Member

s0nea commented May 6, 2020

jenkins render docs

@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented May 6, 2020

Doc render available at http://docs.ceph.com/ceph-prs/34902/

@p-se p-se force-pushed the wip-pse-doc-prom-security branch 2 times, most recently from 9e2825f to 71d84ec Compare May 6, 2020 14:02
@p-se p-se requested review from a team, asettle and liewegas May 6, 2020 14:03
@p-se p-se added the cephadm label May 6, 2020
@p-se p-se marked this pull request as ready for review May 6, 2020 14:04
@p-se p-se requested a review from a team as a code owner May 6, 2020 14:04
@p-se p-se mentioned this pull request May 6, 2020
Merged
3 tasks
asettle
asettle requested changes May 6, 2020
View reviewed changes
@p-se p-se force-pushed the wip-pse-doc-prom-security branch 4 times, most recently from 9885c61 to 07a2198 Compare May 7, 2020 12:19
@p-se
Copy link
Contributor Author

p-se commented May 7, 2020

@LenzGr

LGTM, I left a few small enhancement suggestions. Since this chapter is about Grafana dashboards, it's somewhat irritating to begin it with a warning about Prometheus without giving some context about its role in this scenario.

I've added a few sentences to give a short introduction how Prometheus is related to all this. Thanks for the hint!

@asettle

I've updated the documentation according to your suggestions and our discussion. Thanks for your help!

@tspmelo
Copy link
Contributor

tspmelo commented May 7, 2020

jenkins test make check

@tspmelo
Copy link
Contributor

tspmelo commented May 7, 2020

jenkins test dashboard

s0nea
s0nea reviewed May 11, 2020
View reviewed changes
s0nea
s0nea reviewed May 11, 2020
View reviewed changes
LenzGr
LenzGr reviewed May 11, 2020
View reviewed changes
LenzGr
LenzGr reviewed May 11, 2020
View reviewed changes
@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented May 14, 2020

@LenzGr please merge this as soon as you're ok with this PR.

@p-se p-se force-pushed the wip-pse-doc-prom-security branch from 07a2198 to ac9243f Compare May 15, 2020 13:34
votdev
votdev requested changes May 25, 2020
View reviewed changes
s0nea
s0nea approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@s0nea s0nea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found a minor nit. Besides that LGTM!

LenzGr
LenzGr approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for documenting this.

@p-se
mgr/dashboard: document Prometheus' security model
34765e9 
Fixes: https://tracker.ceph.com/issues/45377

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
@p-se p-se force-pushed the wip-pse-doc-prom-security branch from ac9243f to 34765e9 Compare May 25, 2020 14:51
@sebastian-philipp sebastian-philipp merged commit 9e1e025 into ceph:master May 27, 2020
@sebastian-philipp sebastian-philipp mentioned this pull request Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@votdev votdev votdev approved these changes

@asettle asettle asettle approved these changes

@l-mb l-mb Awaiting requested review from l-mb

@liewegas liewegas Awaiting requested review from liewegas

+2 more reviewers

@LenzGr LenzGr LenzGr approved these changes

@s0nea s0nea s0nea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cephadm dashboard documentation monitoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@p-se @LenzGr @s0nea @ceph-jenkins @tspmelo @sebastian-philipp @votdev @asettle @callithea