kv/RocksDBStore: Reduced verification on sharding#34864
Merged
tchaikov merged 2 commits intoceph:masterfrom May 22, 2020
Merged
kv/RocksDBStore: Reduced verification on sharding#34864tchaikov merged 2 commits intoceph:masterfrom
tchaikov merged 2 commits intoceph:masterfrom
Conversation
jdurgin
approved these changes
Apr 30, 2020
Member
jdurgin
left a comment
There was a problem hiding this comment.
If we want to change the default columns in the future we'll have to remove the check on that as well. this looks good for the immediate issue though
3 tasks
Now sharding is not checked against stored definition. Only check of columns remain. Stored definitons are always applied. Fixes: https://tracker.ceph.com/issues/45335 Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Contributor
Author
|
@jdurgin There is only one change from last review - reenabling default sharding. |
jdurgin
approved these changes
May 20, 2020
Contributor
|
the failures are either tracked or fixed by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now sharding is not checked against stored definition.
Only check of columns remain. Stored definitons are always applied.
Fixes: https://tracker.ceph.com/issues/45335
Signed-off-by: Adam Kupczyk akupczyk@redhat.com