mgr/cephadm: add support for proper osd daemon tracking#34856
Merged
sebastian-philipp merged 2 commits intoceph:masterfrom May 5, 2020
Merged
mgr/cephadm: add support for proper osd daemon tracking#34856sebastian-philipp merged 2 commits intoceph:masterfrom
sebastian-philipp merged 2 commits intoceph:masterfrom
Conversation
Contributor
Author
|
make check failures are legit unit test failures. adapting.. |
liewegas
reviewed
Apr 30, 2020
Contributor
Author
sebastian-philipp
approved these changes
May 4, 2020
Contributor
sebastian-philipp
left a comment
There was a problem hiding this comment.
lgtm minus self.get('osd_metadata')
added 2 commits
May 4, 2020 12:17
Signed-off-by: Joshua Schmid <jschmid@suse.de>
Signed-off-by: Joshua Schmid <jschmid@suse.de>
7d85c3a to
fbed226
Compare
Contributor
Author
|
tests after fixes and rebase: http://pulpito.ceph.com/jschmid-2020-05-05_06:55:50-rados-wip-jschmid1-testing-2020-05-04-1738-distro-basic-smithi/ |
sebastian-philipp
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Schmid jschmid@suse.de
connected to #34835