pybind/mgr: Remove insights/tox.ini#34738
Merged
tchaikov merged 1 commit intoceph:masterfrom May 1, 2020
Merged
Conversation
5 tasks
tchaikov
approved these changes
Apr 24, 2020
Contributor
Author
|
[needs-qa], anyway, the changes to the production code are minimal. |
Contributor
|
jenkins test docs |
tchaikov
requested changes
Apr 26, 2020
Contributor
|
Le lun. 27 avr. 2020 à 05:29, Sebastian Wagner <notifications@github.com> a
écrit :
***@***.**** commented on this pull request.
------------------------------
In src/pybind/mgr/insights/__init__.py
<#34738 (comment)>:
> import os
if 'UNITTEST' not in os.environ:
- from .module import Module
-else:
- import sys
- import mock
- sys.modules['ceph_module'] = mock.Mock()
+ import tests
interesting. since when does teutology set if UNITTEST=True?
teuthology didn’t set this. I think this issue can be fixed by removing
“not” .
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#34738 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAONP4MT6WNPYXQWVM6EU3ROSRURANCNFSM4MQDYY5A>
.
--
Regards
Kefu Chai
|
tchaikov
reviewed
Apr 27, 2020
All we need is part of mgr/tox.ini nowadays. Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
9e88e74 to
1f88981
Compare
tchaikov
approved these changes
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All we need is part of mgr/tox.ini nowadays.
This PR blocks #33886
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox