Merged
Conversation
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Contributor
|
@cbodley, I cherry picked the commits on top of my local branch to test, and I noticed that it creates buckets with num_shards = 11. The changes here doesn't seem to be causing it. Will check further and update. |
mattbenjamin
approved these changes
Apr 16, 2020
| uint32_t hash_type; | ||
| JSONDecoder::decode_json("bi_shard_hash_type", hash_type, obj); | ||
| layout.current_index.layout.normal.num_shards = (uint8_t)hash_type; | ||
| layout.current_index.layout.normal.hash_type = static_cast<rgw::BucketHashType>(hash_type); |
| { | ||
| int r = 0; | ||
| switch (hash_type) { | ||
| case RGWBucketInfo::MOD: |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a couple followup fixes for #34096
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox