mgr/cephadm: nfs common config#34249
Merged
sebastian-philipp merged 3 commits intoceph:masterfrom Apr 9, 2020
Merged
Conversation
jtlayton
approved these changes
Mar 31, 2020
Contributor
|
Looks fine to me, but I think it will need rebasing. |
Signed-off-by: Michael Fritch <mfritch@suse.com>
instead of a per-daemon RADOS conf object Signed-off-by: Michael Fritch <mfritch@suse.com>
populate `rados_config_location` in the ServiceDescription with the RADOS url of the "common" config Signed-off-by: Michael Fritch <mfritch@suse.com>
e640151 to
05a9a1b
Compare
varshar16
approved these changes
Apr 1, 2020
Contributor
|
@varshar16 do you plan to add a cephadm + nfs volumes test to teuthology? |
Contributor
Yes, I will be adding it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the per-daemon RADOS config in favor of a simplified approach using a single RADOS common config.
Signed-off-by: Michael Fritch mfritch@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox