msg/async/ProtocolV2: fix typo in register_lossy_clients fix#33559
Merged
dillaman merged 2 commits intoceph:masterfrom Feb 27, 2020
Merged
msg/async/ProtocolV2: fix typo in register_lossy_clients fix#33559dillaman merged 2 commits intoceph:masterfrom
dillaman merged 2 commits intoceph:masterfrom
Conversation
In 507d213 this was typoed, reversing the condition. Fixes: https://tracker.ceph.com/issues/42328 Signed-off-by: Sage Weil <sage@redhat.com>
neha-ojha
approved these changes
Feb 26, 2020
Member
Author
|
retest this please |
|
@liewegas It's still failing w/ out-of-order ops [1] on my latest test branch [2]. [1] http://qa-proxy.ceph.com/teuthology/jdillaman-2020-02-26_18:52:47-rbd-wip-jd-testing-distro-basic-smithi/4805834/teuthology.log |
Member
Author
|
@dillaman ok looks like I missed a condition back when introducing the policy flag. Can you retest with the new patch? |
|
@liewegas 🍾 RBD tests are passing! 🎉 |
Member
Author
🎆 omg finally. thanks for testing!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 507d213 this was typoed, reversing
the condition.
Fixes: https://tracker.ceph.com/issues/42328
Signed-off-by: Sage Weil sage@redhat.com