Skip to content

pyind/mgr: add mgr_module.py and mgr_util.py to mypy#32597

Merged
sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp:mgr-mypy-mgr_util-mgr_module
Jan 13, 2020
Merged

pyind/mgr: add mgr_module.py and mgr_util.py to mypy#32597
sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp:mgr-mypy-mgr_util-mgr_module

Conversation

@sebastian-philipp
Copy link
Contributor

Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com

... and yet another tiny step towards finding type errors earlier

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jan 10, 2020

181/192 Test #187: unittest_seastar_socket .................***Failed    3.35 sec

@sebastian-philipp
Copy link
Contributor Author

jenkins test make check

@sebastian-philipp sebastian-philipp merged commit 24aa280 into ceph:master Jan 13, 2020
@sebastian-philipp sebastian-philipp deleted the mgr-mypy-mgr_util-mgr_module branch January 13, 2020 10:08
Copy link
Member

@votdev votdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants