qa/tasks/mgr: set mgr module option with --force#32588
Merged
tchaikov merged 1 commit intoceph:masterfrom Jan 10, 2020
Merged
Conversation
if mgr is not active, monitor will refuse to set any option consumed by mgr modules. the reason the tests pass somtimes is that, we have a racing here: 1. stop all mgr daemons 2. MgrMonitor gets updated and updates its mgr_module_options accordingly. 3. in TestDashboard.setUp(), we reset the port number for dashboard using "ceph config set mgr mgr/dashboard/y/ssl_server_port 7789" 4. restart all mgr daemons but the 2nd step and 3rd step could race with each other, if the 2nd step happens after 3rd step, the test passes. otherwise it fails. in this change, "--force" is passed to the "ceph config set" command, so ConfigMonitor can bypass the sanity test for the option, and just set this option. Signed-off-by: Kefu Chai <kchai@redhat.com>
Contributor
Author
|
this change should address the failure of http://pulpito.ceph.com/kchai-2020-01-10_01:36:54-rados-wip-kefu-testing-2020-01-10-0001-distro-basic-smithi/4650559/ |
Contributor
Author
|
jenkins test make check |
1 similar comment
Contributor
Author
|
jenkins test make check |
This was referenced Jan 10, 2020
This was referenced Jan 10, 2020
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if mgr is not active, monitor will refuse to set any option consumed by
mgr modules.
the reason the tests pass somtimes is that, we have a racing here:
accordingly.
using "ceph config set mgr mgr/dashboard/y/ssl_server_port 7789"
but the 2nd step and 3rd step could race with each other, if the 2nd
step happens after 3rd step, the test passes. otherwise it fails.
in this change, "--force" is passed to the "ceph config set" command,
so ConfigMonitor can bypass the sanity test for the option, and just
set this option.
Signed-off-by: Kefu Chai kchai@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox