Skip to content

mgr/dashboard: fix failing user test#32461

Merged
tchaikov merged 1 commit intoceph:masterfrom
s0nea:wip-dashboard-fix-user-test
Jan 8, 2020
Merged

mgr/dashboard: fix failing user test#32461
tchaikov merged 1 commit intoceph:masterfrom
s0nea:wip-dashboard-fix-user-test

Conversation

@s0nea
Copy link
Member

@s0nea s0nea commented Jan 2, 2020

Choose another future_date_1 date (9 days instead of 10) to make sure the expiration date will be between future_date_1 and future_date_2. Otherwise the expiration date might be equal to future_date_1.

Fixes: https://tracker.ceph.com/issues/43431
Signed-off-by: Tatjana Dehler tdehler@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Copy link
Contributor

@p-se p-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@s0nea
Copy link
Member Author

s0nea commented Jan 2, 2020

jenkins test make check

Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Choose another future_date_1 date (9 days instead of 10) to
make sure the expiration date will be between future_date_1
and future_date_2. Otherwise the expiration date might be
equal to future_date_1.
Also wait for 10 seconds before the password refresh in
test_pwd_expiration_date_update to prevent date equality.

Fixes: https://tracker.ceph.com/issues/43431
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
@s0nea s0nea force-pushed the wip-dashboard-fix-user-test branch from 20966d3 to b9094f1 Compare January 7, 2020 10:57
@s0nea
Copy link
Member Author

s0nea commented Jan 7, 2020

jenkins test dashboard backend

@callithea
Copy link
Member

jenkins test dashboard backend

@s0nea
Copy link
Member Author

s0nea commented Jan 7, 2020

@tchaikov tchaikov merged commit 93fd11d into ceph:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants