common/admin_socket: Increase socket timeouts#31623
Conversation
With the move of the 'bench' command to the admin socket the recv timeout is being exceeded in testing due to the duration of the command. Fixes: https://tracker.ceph.com/issues/42387 Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
|
Since this is an arbitrary limit I'm looking for feedback as to whether this is a sufficient "fix" From my testing the 'bench' command does not exceed 10 seconds but some future command may? |
|
It is a bit arbitrary... but as long as it's > the default bench duration it's probably fine? |
|
@liewegas the default bench duration is dependant on the speed of the storage (by default we write bench count 1073741824 bsize 4 MiB (default count=1G default size=4MB)). I can break it with the new timeout values by sending '{"prefix":"bench", "count": 2147483648}' to the admin socket. We could set SO_RCVTIMEO to zero and disable timeouts and accept what comes with that or we could set a fair bit larger value and hope no one ever hits it? |
|
Of course we could also make it user-configurable (which might be wise). |
|
@liewegas If you're happy with this as it stands (based on our IRC conversation) could you ACK it? |
liewegas
left a comment
There was a problem hiding this comment.
This change seems fine on its face.. the timeout is arbitrary. We should keep in mind that the bench command could be improved in the future to not block the asok thread, though. I'm not sure it really matters given it's not something you'd normally do to a production system.
With the move of the 'bench' command to the admin socket the recv
timeout is being exceeded in testing due to the duration of the command.
Fixes: https://tracker.ceph.com/issues/42387
Signed-off-by: Brad Hubbard bhubbard@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox