nautilus: ceph.in: check ceph-conf returncode#31367
Merged
yuriw merged 1 commit intoceph:nautilusfrom Dec 18, 2019
Merged
Conversation
When running the ceph-conf command, we only check the stderr output. When the ceph configuration file has duplicate values then the ceph daemon command will fail because the stderr will contain the warning message but the ceph-conf return code is 0. $ ceph-conf --name mon.cephaio-1 --show-config-value admin_socket warning: line 13: 'osd_memory_target' in section 'osd' redefined /var/run/ceph/ceph-mon.cephaio-1.asok $ echo $? 0 Fixes: https://tracker.ceph.com/issues/37664 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com> (cherry picked from commit e69aea6)
smithfarm
approved these changes
Dec 13, 2019
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/42400
backport of #30695
parent tracker: https://tracker.ceph.com/issues/37664
this backport was staged using ceph-backport.sh version 15.0.0.6612
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh